Review main Merged

89312[BUGFIX] Handle 'record' links in TypolinkTagSoftReferenceParser

Sybille Peters CR +2 V +2 Normal +177 −12 updated 09/24/26, 21:38

Commit message

The soft reference parser for `<a>` tags, used for RTE fields, handled
files, pages, URLs, emails and phone numbers, but not record links
like `t3://record?identifier=tx_news&uid=99`. They fell through to
`AppendLinkHandlerElementsEvent`, which nothing in Core handles, and
were silently skipped. As a result no `sys_refindex` entries were
created for record links in RTE fields and EXT:linkvalidator could
not check them.

The parser now returns a `db` element with `table:uid` as record
reference, like `TypolinkSoftReferenceParser` does for typolink
fields. The lookup of the table for a link handler identifier is
moved into `AbstractSoftReferenceParser` and shared by both parsers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 2032

Show 57 earlier messages
  1. Sybille Peters uploaded patch set 1 05/07/25, 09:11

  2. core-ci voted on patch set 1 V +1 05/07/25, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78628

  3. Georg Ringer updated the commit message in patch set 2 V +1 05/07/25, 13:07

  4. core-ci voted on patch set 2 V +1 05/07/25, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78636

  5. Sybille Peters commented on patch set 2 CR -1 05/07/25, 13:31

    Still working on tests ...
  6. Sybille Peters uploaded patch set 3 CR -1 V +1 05/07/25, 17:24

  7. Sybille Peters updated the commit message in patch set 4 05/07/25, 17:28

  1. core-ci voted on patch set 3 V -1 05/07/25, 17:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78640

  2. core-ci voted on patch set 4 V -1 05/07/25, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78641

  3. Sybille Peters uploaded patch set 5 V -1 05/07/25, 17:47

  4. core-ci voted on patch set 5 V +1 05/07/25, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78642

  5. Sybille Peters uploaded patch set 6 V +1 05/08/25, 05:48

  6. core-ci voted on patch set 6 V +1 05/08/25, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78654

  7. Sybille Peters rebased onto patch set 7 V +1 07/31/25, 15:17

  8. core-ci voted on patch set 7 V +1 07/31/25, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82592

  9. Benni Mack voted on patch set 7 CR +1 V +1 07/31/25, 16:39

  10. Benni Mack uploaded patch set 8 CR +1 V +1 08/01/25, 16:25

  11. Benni Mack voted on patch set 8 CR +1 V +1 08/01/25, 16:25

  12. core-ci voted on patch set 8 V -1 08/01/25, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82640

  13. Benni Mack commented on patch set 9 CR +1 V +1 08/14/25, 18:18

    Published edit on patch set 8.
  14. core-ci voted on patch set 9 V -1 08/14/25, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83404

  15. Benni Mack commented on patch set 10 V -1 08/14/25, 19:27

    Published edit on patch set 9.
  16. core-ci voted on patch set 10 V -1 08/14/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83407

  17. Benni Mack wrote 04/21/26, 15:01

    Removed reviewer Benni Mack.
  18. Benni Mack updated the commit message in patch set 11 V -1 04/22/26, 06:53

  19. core-ci voted on patch set 11 V -1 04/22/26, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100824

  20. Benni Mack uploaded patch set 12 V -1 09/24/26, 04:43

  21. Benni Mack voted on patch set 12 CR +1 V +1 09/24/26, 04:45

  22. core-ci voted on patch set 12 V +1 09/24/26, 04:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109137

  23. Wouter Wolters voted on patch set 12 CR +1 V +1 09/24/26, 21:20

  24. Benni Mack voted on patch set 12 CR +2 V +2 09/24/26, 21:38

  25. Benni Mack merged patch set 13 09/24/26, 21:38