Review 13.4 Merged

89319[BUGFIX] Respect per-site conditions in TS cache identifiers

Christian Kuhn CR +2 V +2 Normal +75 −7 updated 05/08/25, 13:42

Commit message

There are multiple cache layers around TypoScript parsing in
order to do the least amount of work when accessing FE pages.

One of that is a cached list of TypoScript conditions with
their verdicts. It determines if full TS needs to be loaded
and allows retrieving full TS from cache if a previous call
to a different page calculated that TS with these condition
verdicts already.

The condition list with verdicts can be different across
different site sets, the cache identifier thus needs to
reflect different sets. This is added with the patch. A
functional test proofs correctness of this scenario.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • André Buchmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • André Buchmann +1
    • core-ci +1 CI

Issues 3

Files 7

Review log 45

  1. Christian Kuhn uploaded patch set 1 05/08/25, 12:54

  2. core-ci voted on patch set 1 V +1 05/08/25, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78667

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 05/08/25, 13:38

  4. Christian Kuhn merged patch set 2 05/08/25, 13:38

  5. André Buchmann voted on patch set 2 CR +1 V +1 05/08/25, 13:42