Review main Merged

89321[FEATURE] Use FormEngine and DataHandler for scheduler

Benni Mack CR +2 V +2 Expert +982 −166 updated 05/27/25, 11:29

Commit message

This change is the last one in a list of several
parts to unify the handling of scheduler tasks
with the rest of TYPO3's major Backend APIs - which
is TCA, FormEngine, and DataHandler.

The editing interface for scheduler tasks now
use FormEngine with custom render types to show
additional fields and the timing information.

The persisting part is now handled via DataHandler
with a custom hook to reduce special handling
with the SchedulerTaskRepository.

A RST file is added to also explain the advantages
of using TCA, DataHandler and FormEngine for
scheduler tasks (customizing, audit trail, import/export).

Next Steps:
- Remove a lot of unused code from EXT:scheduler
- Registration change and custom TCA types

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 30

Show 10 more files

Review log 3761

Show 1936 earlier messages
  1. Benni Mack uploaded patch set 1 05/09/25, 06:34

  2. core-ci voted on patch set 1 V -1 05/09/25, 06:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78719

  3. Benni Mack uploaded patch set 2 V -1 05/09/25, 14:57

  4. core-ci voted on patch set 2 V -1 05/09/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78734

  5. Benni Mack uploaded patch set 3 V -1 05/12/25, 09:40

  6. core-ci voted on patch set 3 V -1 05/12/25, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78800

  7. Benni Mack uploaded patch set 4 V -1 05/16/25, 16:55

  8. core-ci voted on patch set 4 V -1 05/16/25, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79078

  9. Benni Mack uploaded patch set 5 V -1 05/18/25, 19:16

  10. core-ci voted on patch set 5 V -1 05/18/25, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79110

  11. Benni Mack uploaded patch set 6 V -1 05/21/25, 07:56

  12. core-ci voted on patch set 6 V -1 05/21/25, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79275

  13. Benni Mack uploaded patch set 7 V -1 05/21/25, 08:26

  14. core-ci voted on patch set 7 V -1 05/21/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79278

  15. Benni Mack uploaded patch set 8 V -1 05/21/25, 08:52

  16. core-ci voted on patch set 8 V -1 05/21/25, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79282

  17. Benni Mack uploaded patch set 9 V -1 05/21/25, 11:55

  18. core-ci voted on patch set 9 V -1 05/21/25, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79298

  19. Benni Mack uploaded patch set 10 V -1 05/21/25, 14:28

  20. core-ci voted on patch set 10 V -1 05/21/25, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79311

  21. Benni Mack uploaded patch set 11 V -1 05/21/25, 14:45

  22. core-ci voted on patch set 11 V -1 05/21/25, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79317

  23. Stefan Bürk uploaded patch set 12 V -1 05/21/25, 19:23

  24. core-ci voted on patch set 12 V -1 05/21/25, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79327

  25. Stefan Bürk uploaded patch set 13 V -1 05/21/25, 20:14

  26. core-ci voted on patch set 13 V +1 05/21/25, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79328

  27. core-ci voted on patch set 13 V -1 05/21/25, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79329

  28. Stefan Bürk uploaded patch set 14 V -1 05/21/25, 20:45

  29. core-ci voted on patch set 14 V +1 05/21/25, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79330

  30. core-ci commented on patch set 14 05/21/25, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79331

  31. Stefan Bürk commented on patch set 15 V +1 05/22/25, 14:04

    Published edit on patch set 14.
  32. Christian Kuhn commented on patch set 14 05/22/25, 14:13

    SchedulerModuleController.php:61

    please avoid adding new class state: hand this over to the consuming method as argumnt.

    SchedulerModuleController.php:208

    do you have a strategy to refactor this away entirely somehow? it is also very unfortunate that the formEngine element and the DH hook get the controller injected ...
  33. core-ci voted on patch set 15 V +1 05/22/25, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79377

  34. Benni Mack commented on patch set 15 05/22/25, 14:31

    SchedulerModuleController.php:208 Reply

    the next step is to not use the AdditionalFieldProviders anymore (= breaking) but use TCA types. This way, all of this logic will be deprecated / removed. The worst part about the AdditionalFieldProvider is that it gets handed in the SchedulerModuleController as argument (in the interface). This must go away completely.
  35. Stefan Bürk commented on patch set 15 05/22/25, 14:47

    TaskService.php:198

    Using the available task/commands overview does not work. Adding a command from that list clicking on `+` leads to a exception in the TaskService related to this `str_contains()` call: ``` str_contains(): Argument #1 ($haystack) must be o type string, array given ``` $fieldInfo['code'] is an array with `html` and `optionValueField` subkeys in this cases ....
  36. Benni Mack uploaded patch set 16 V +1 05/22/25, 15:46

  1. Benni Mack commented on patch set 16 05/22/25, 15:47

    SchedulerModuleController.php:61 Reply

    done!

    SchedulerModuleController.php:208 Reply

    Done

    TaskService.php:198 Reply

    thanks, fixed!
  2. core-ci voted on patch set 16 V +1 05/22/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79386

  3. Christian Kuhn commented on patch set 16 05/22/25, 16:51

    SchedulerModuleController.php:208 Reply

    yeah. i remember now. having the controller hand over to the additional field provider was a huge headache already when i refactored the controller in v12. will be great to see this gone.
  4. Benni Mack uploaded patch set 17 V +1 05/22/25, 19:05

  5. core-ci voted on patch set 17 V +1 05/22/25, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79389

  6. Benni Mack rebased onto patch set 18 V +1 05/26/25, 10:34

  7. core-ci voted on patch set 18 V +1 05/26/25, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79478

  8. Christian Kuhn commented on patch set 18 05/26/25, 12:17

    on it.
  9. Oli Bartsch uploaded patch set 19 V +1 05/26/25, 13:44

  10. core-ci voted on patch set 19 V -1 05/26/25, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79494

  11. Oli Bartsch uploaded patch set 20 V -1 05/26/25, 14:46

  12. core-ci voted on patch set 20 V +1 05/26/25, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79499

  13. Georg Ringer voted on patch set 20 CR +1 V +1 05/26/25, 19:03

  14. Andreas Kienast commented on patch set 20 CR -1 05/27/25, 06:52

    on it
  15. Andreas Kienast uploaded patch set 21 CR +1 V +1 05/27/25, 07:11

  16. Andreas Kienast commented on patch set 21 V -1 05/27/25, 07:12

    Reply

    Done
    When I edit a persisted scheduler task and switch the running type from "Single" to "Recurring", the field "Run periodically until" is set to "now". This seems bogus, doesn't it?
  17. core-ci voted on patch set 21 V +1 05/27/25, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79545

  18. Benni Mack commented on patch set 21 05/27/25, 07:43

    Reply

    should be empty
  19. Andreas Kienast commented on patch set 21 05/27/25, 08:38

    Reply

    Apparently the reason is that a newly created task has `end` defined in its execution details, which is then used for the artificial `end` field.
  20. Benni Mack uploaded patch set 22 V +1 05/27/25, 10:11

  21. Benni Mack commented on patch set 22 05/27/25, 10:11

    Reply

    Done
  22. core-ci voted on patch set 22 V +1 05/27/25, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79550

  23. Andreas Kienast voted on patch set 22 CR +1 V +1 05/27/25, 10:34

  24. Georg Ringer voted on patch set 22 CR +2 V +2 05/27/25, 11:29

  25. Georg Ringer merged patch set 23 05/27/25, 11:29