89321[FEATURE] Use FormEngine and DataHandler for scheduler
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 30
- Build/Sources/TypeScript/backend/form-engine.ts+19 −1
- Build/Sources/TypeScript/scheduler/form-engine/element/timing-options-element.tsnew+74 −0
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+2 −2
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-106739-SchedulerTasksAsNativeTCATable.rstnew+43 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/CategoryTreeCest.php+6 −1
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.php+7 −3
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+17 −40
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTaskNotificationEmailField.php+3 −3
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php6+48 −22
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php+28 −42
- typo3/sysext/scheduler/Classes/Form/Element/AdditionalSchedulerFieldsElement.phpnew+124 −0
- typo3/sysext/scheduler/Classes/Form/Element/TimingOptionsElement.phpnew+186 −0
- typo3/sysext/scheduler/Classes/Hooks/SchedulerTaskPersistenceValidator.phpnew+245 −0
- typo3/sysext/scheduler/Classes/Service/TaskService.php2+54 −13
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+2 −1
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandTask.php+1 −1
- typo3/sysext/scheduler/Classes/Execution.php+1 −1
- typo3/sysext/scheduler/Classes/Scheduler.php+1 −1
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task.php+35 −12
Show 10 more files
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditAdditionalFields.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/GroupUnusedList.html+2 −2
- typo3/sysext/scheduler/Resources/Private/Partials/ServerTime.html+0 −1
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+18 −10
- typo3/sysext/scheduler/Resources/Private/Templates/AdditionalFields.htmlnew+8 −0
- typo3/sysext/scheduler/Resources/Private/Templates/InfoScreen.html+8 −7
- typo3/sysext/scheduler/Resources/Private/Templates/ServerTime.htmlnew+10 −0
- typo3/sysext/scheduler/Resources/Public/JavaScript/form-engine/element/timing-options-element.jsnew+13 −0
- typo3/sysext/scheduler/ext_localconf.php+15 −0
Review log 3761
Show 1936 earlier messages
-
Benni Mack uploaded patch set 1 05/09/25, 06:34
-
core-ci voted on patch set 1 V -1 05/09/25, 06:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78719
-
Benni Mack uploaded patch set 2
V -105/09/25, 14:57 -
core-ci voted on patch set 2 V -1 05/09/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78734
-
Benni Mack uploaded patch set 3
V -105/12/25, 09:40 -
core-ci voted on patch set 3 V -1 05/12/25, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78800
-
Benni Mack uploaded patch set 4
V -105/16/25, 16:55 -
core-ci voted on patch set 4 V -1 05/16/25, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79078
-
Benni Mack uploaded patch set 5
V -105/18/25, 19:16 -
core-ci voted on patch set 5 V -1 05/18/25, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79110
-
Benni Mack uploaded patch set 6
V -105/21/25, 07:56 -
core-ci voted on patch set 6 V -1 05/21/25, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79275
-
Benni Mack uploaded patch set 7
V -105/21/25, 08:26 -
core-ci voted on patch set 7 V -1 05/21/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79278
-
Benni Mack uploaded patch set 8
V -105/21/25, 08:52 -
core-ci voted on patch set 8 V -1 05/21/25, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79282
-
Benni Mack uploaded patch set 9
V -105/21/25, 11:55 -
core-ci voted on patch set 9 V -1 05/21/25, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79298
-
Benni Mack uploaded patch set 10
V -105/21/25, 14:28 -
core-ci voted on patch set 10 V -1 05/21/25, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79311
-
Benni Mack uploaded patch set 11
V -105/21/25, 14:45 -
core-ci voted on patch set 11 V -1 05/21/25, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79317
-
Stefan Bürk uploaded patch set 12
V -105/21/25, 19:23 -
core-ci voted on patch set 12 V -1 05/21/25, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79327
-
Stefan Bürk uploaded patch set 13
V -105/21/25, 20:14 -
core-ci voted on patch set 13 V +1 05/21/25, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79328
-
core-ci voted on patch set 13 V -1 05/21/25, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79329
-
Stefan Bürk uploaded patch set 14
V -105/21/25, 20:45 -
core-ci voted on patch set 14 V +1 05/21/25, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79330
-
core-ci commented on patch set 14 05/21/25, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79331
-
Stefan Bürk commented on patch set 15
V +105/22/25, 14:04Published edit on patch set 14. -
Christian Kuhn commented on patch set 14 05/22/25, 14:13
SchedulerModuleController.php:61please avoid adding new class state: hand this over to the consuming method as argumnt.SchedulerModuleController.php:208do you have a strategy to refactor this away entirely somehow? it is also very unfortunate that the formEngine element and the DH hook get the controller injected ... -
core-ci voted on patch set 15 V +1 05/22/25, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79377
-
Benni Mack commented on patch set 15 05/22/25, 14:31
SchedulerModuleController.php:208Replythe next step is to not use the AdditionalFieldProviders anymore (= breaking) but use TCA types. This way, all of this logic will be deprecated / removed. The worst part about the AdditionalFieldProvider is that it gets handed in the SchedulerModuleController as argument (in the interface). This must go away completely. -
Stefan Bürk commented on patch set 15 05/22/25, 14:47
TaskService.php:198Using the available task/commands overview does not work. Adding a command from that list clicking on `+` leads to a exception in the TaskService related to this `str_contains()` call: ``` str_contains(): Argument #1 ($haystack) must be o type string, array given ``` $fieldInfo['code'] is an array with `html` and `optionValueField` subkeys in this cases .... -
Benni Mack uploaded patch set 16
V +105/22/25, 15:46
-
Benni Mack commented on patch set 16 05/22/25, 15:47
SchedulerModuleController.php:61Replydone!SchedulerModuleController.php:208ReplyDoneTaskService.php:198Replythanks, fixed! -
core-ci voted on patch set 16 V +1 05/22/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79386
-
Christian Kuhn commented on patch set 16 05/22/25, 16:51
SchedulerModuleController.php:208Replyyeah. i remember now. having the controller hand over to the additional field provider was a huge headache already when i refactored the controller in v12. will be great to see this gone. -
Benni Mack uploaded patch set 17
V +105/22/25, 19:05 -
core-ci voted on patch set 17 V +1 05/22/25, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79389
-
Benni Mack rebased onto patch set 18
V +105/26/25, 10:34 -
core-ci voted on patch set 18 V +1 05/26/25, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79478
-
Christian Kuhn commented on patch set 18 05/26/25, 12:17
on it. -
Oli Bartsch uploaded patch set 19
V +105/26/25, 13:44 -
core-ci voted on patch set 19 V -1 05/26/25, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79494
-
Oli Bartsch uploaded patch set 20
V -105/26/25, 14:46 -
core-ci voted on patch set 20 V +1 05/26/25, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79499
-
Georg Ringer voted on patch set 20 CR +1 V +1 05/26/25, 19:03
-
Andreas Kienast commented on patch set 20 CR -1 05/27/25, 06:52
on it -
Andreas Kienast uploaded patch set 21
CR +1V +105/27/25, 07:11 -
Andreas Kienast commented on patch set 21 V -1 05/27/25, 07:12
Reply
DoneWhen I edit a persisted scheduler task and switch the running type from "Single" to "Recurring", the field "Run periodically until" is set to "now". This seems bogus, doesn't it? -
core-ci voted on patch set 21 V +1 05/27/25, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79545
-
Benni Mack commented on patch set 21 05/27/25, 07:43
Reply
should be empty -
Andreas Kienast commented on patch set 21 05/27/25, 08:38
Reply
Apparently the reason is that a newly created task has `end` defined in its execution details, which is then used for the artificial `end` field. -
Benni Mack uploaded patch set 22
V +105/27/25, 10:11 -
Benni Mack commented on patch set 22 05/27/25, 10:11
Reply
Done -
core-ci voted on patch set 22 V +1 05/27/25, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79550
-
Andreas Kienast voted on patch set 22 CR +1 V +1 05/27/25, 10:34
-
Georg Ringer voted on patch set 22 CR +2 V +2 05/27/25, 11:29
-
Georg Ringer merged patch set 23 05/27/25, 11:29