89324[TASK] Introduce TCA for tx_scheduler_task
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Stefan Froemken +1
-
Verified V +2 Done
- Stefan Bürk +2
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php3+20 −111
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php11+84 −48
- typo3/sysext/scheduler/Classes/Service/TaskService.php7+102 −0
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+1 −14
- typo3/sysext/scheduler/Classes/Execution.php2+14 −0
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task.php9new+137 −0
- typo3/sysext/scheduler/Resources/Private/Language/locallang_tca.xlf2+30 −0
- typo3/sysext/scheduler/ext_tables.sql+0 −16
Review log 2533
Show 48 earlier messages
-
Benni Mack uploaded patch set 1 05/09/25, 08:29
-
core-ci voted on patch set 1 V -1 05/09/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78723
-
Benni Mack uploaded patch set 2
V -105/09/25, 09:00 -
core-ci voted on patch set 2 V -1 05/09/25, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78724
-
Benni Mack uploaded patch set 3
V -105/09/25, 09:34 -
Benni Mack updated the commit message in patch set 4 05/09/25, 09:36
-
core-ci voted on patch set 3 V +1 05/09/25, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78725
-
core-ci voted on patch set 4 V +1 05/09/25, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78726
-
Stefan Bürk commented on patch set 4 05/09/25, 10:17
-
Stefan Bürk uploaded patch set 5
V +105/09/25, 10:30 -
Stefan Bürk commented on patch set 5 05/09/25, 10:30
TaskService.php:163ReplyDone -
core-ci voted on patch set 5 V +1 05/09/25, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78727
-
Stefan Bürk voted on patch set 5 CR +1 V +1 05/09/25, 10:36
-
Andreas Kienast commented on patch set 5 05/09/25, 11:43
SchedulerModuleController.php:586Should we directly `return false` if the array is empty? Otherwise we'll get an array key error in line 588 (yeah, that was the case previously as well).TaskService.php:177AFAICS `cshKey` and `cshLabel` are not used anymore. If that's true, we should get rid of it in another patch.tx_scheduler_task.php:74I wonder whether we should mark those management fields as "readonly" already or wait until we have FormEngine in place. -
Stefan Bürk commented on patch set 5 05/09/25, 11:52
SchedulerModuleController.php:586ReplyWe can do that, but even if it is not empty that array "may" happen if field is not provided. So guarding it is required anyway. Good catch !tx_scheduler_task.php:74ReplyI would wait and handle this within the formengine patch, where it is visible which needs to be set and checked/verified if it would lead to persisting errors or not and similar. Would that be okay for you ? -
Stefan Bürk uploaded patch set 6
CR +1V +105/09/25, 11:52 -
Stefan Bürk commented on patch set 6 05/09/25, 11:52
SchedulerModuleController.php:586ReplyDone -
Andreas Kienast commented on patch set 6 05/09/25, 11:54
tx_scheduler_task.php:74ReplyAcknowledged -
core-ci voted on patch set 6 V +1 05/09/25, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78729
-
Stefan Bürk voted on patch set 6 CR +1 V +1 05/09/25, 11:59
-
Stefan Froemken commented on patch set 6 05/09/25, 12:48
SchedulerTaskRepository.php:91Can you make sure this is INT? Currently setTaskUid will cast that value to int. But as we try to implement more typed arguments I would prefer to cast that value hereSchedulerTaskRepository.php:116We have TCA now. Please use enablefields|deleteSchedulerTaskRepository.php:120Is OK, but I prefer calling process_datamap() before. Method unsetElementsToBeDeleted will check for deleted elements between datamap and cmdmap. But as datamap is empty here, it's OK for now.SchedulerTaskRepository.php:153Do we still need these annotations? I mean, we have .phpstorm.meta.php, there are IDE plugins supporting this. If you have an unsupported IDE I prefer moving that into a getDataHandler method and given return type will solve that issue much better.SchedulerTaskRepository.php:422We have TCA now, so I prefer using enablecolumns|disable insteadExecution.php:351```suggestion return !empty($this->getInterval()) || !empty($this->getCronCmd()); ```TaskService.php:174Don't know, if this is an int, but if so, please cast to INTTaskService.php:182pageUid seems to be an INT. Are you sure we should use empty string, if pageUid is not set? I prefer ```suggestion 'pageUid' => (int)($fieldInfo['pageUid'] ?? 0), ```tx_scheduler_task.php:47Move that before items -
Stefan Froemken voted on patch set 6 CR -1 05/09/25, 12:49
-
Stefan Froemken commented on patch set 6 05/09/25, 12:52
tx_scheduler_task.php:77In earlier version it was "INT unsigned". Can we set is to unsigned here, too?tx_scheduler_task.php:83In earlier version it was "INT unsigned". Can we set is to unsigned here, too? -
Stefan Froemken commented on patch set 6 05/09/25, 12:59
locallang_tca.xlf:22```suggestion <source>Schedule</source> ``` Or maybe "Execution time". -
Benni Mack uploaded patch set 7
CR +1V +105/09/25, 14:37 -
Benni Mack commented on patch set 6 05/09/25, 14:39
SchedulerTaskRepository.php:91ReplyDoneSchedulerTaskRepository.php:116Replywhat are you talking about? This is the "delete" command from DataHandler, and that's the syntax to trigger this for DataHandler. I guess you mix this with the "dataMap" even though this is the "cmdMap".SchedulerTaskRepository.php:120Replythis is the correct way. If you only fill only the cmdmap you don't need to call process_datamap().SchedulerTaskRepository.php:153Replyyes. we can remove themSchedulerTaskRepository.php:422ReplyDoneExecution.php:351ReplyDoneTaskService.php:174Replysorry, not an integerTaskService.php:182ReplyDonetx_scheduler_task.php:47ReplyDonetx_scheduler_task.php:77Replynot possible with DefaultTcaSchematx_scheduler_task.php:83Replynot possible with DefaultTcaSchemalocallang_tca.xlf:22ReplyCurrent label in module is also Timing, but I do like Schedule. -
core-ci voted on patch set 7 V +1 05/09/25, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78731
-
Benni Mack uploaded patch set 8 05/09/25, 14:57
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 8 V +1 05/09/25, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78733
-
Stefan Bürk commented on patch set 8 CR +1 V +1 05/10/25, 08:38
SchedulerTaskRepository.php:116ReplySee: * https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/DataHandler/Database/Index.html#confval-datahandler-cmd-delete * https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/DataHandler/Database/Index.html#confval-datahandler-cmd-delete ``` $cmd['tt_content'][54]['delete'] = 1; // Deletes tt_content record with uid=54 ``` -
Stefan Froemken voted on patch set 8 CR +1 V +1 05/10/25, 13:45
-
Stefan Bürk voted on patch set 8 CR +2 V +2 05/10/25, 13:49
-
Stefan Bürk merged patch set 9 05/10/25, 13:49
TaskService.php:163