Review 13.4 Merged

89332[TASK] Add GUI-managed map (keys+values) and list for Configuration

Benni Mack CR +2 V +2 Hard +301 −8 updated 05/13/25, 08:10

Commit message

This patch allows to manage PHP arrays with keys and values ("map")
and array with numerical keys and values ("element-list") in the
backend module "Admin Tools > Settings > Configure Installation-Wide
Options".

Currently, array values like GFX.processor_stripColorProfileParameters
contain an input box where array values need to be entered
by maintainers/integrators separated by a comma. This is prone to
errors and visually not appealing.

With this patch, key/value pairs (or just value lists) are shown inside
a table, where each row can be removed or new rows
added. This works both with string-indexed maps and also
numerical indexes.

For this, the type "map" has been created,
and a similar GUI is available for "element-list",
where only array values are maintained. Note that the
type "list" was already utilized for a single input text
with commaseparated values, so the new type needed a
distinct naming.

Some configuration options [1] have been converted from
"array" to "element-list" to showcase this, and a
demo option "GFX.imagefile_defaultProcessing" has been
added (see #93981, see patchsets up to PS11).

This allows for a resulting configuration like:

```
'imagefile_defaultProcessing' = [
  'default' => 'png',
  'jpg'     => 'avif',
  'webp'    => 'avif',
]
```

SCREENSHOTS:

https://www.dropbox.com/scl/fi/t8jcmbmadlzkh48oew2xd/Screenshot-2025-04-11-at-10.32.36.png?rlkey=5asx0y95u0rxqk0dw5y0aejbz&dl=1
https://www.dropbox.com/scl/fi/synvsizzrmnqzmq0iwyt6/Screenshot-2025-04-11-at-10.36.58.png?rlkey=24t7eunq9jtog70njl01vxb9r&dl=1

[1] GFX.processor_stripColorProfileParameters
    SYS.allowedPhpDisableFunctions
    BE.lockRootPath

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 05/10/25, 13:49

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/10/25, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78751

  3. Benni Mack voted on patch set 1 CR +2 V +2 05/13/25, 08:10

  4. Benni Mack merged patch set 2 05/13/25, 08:10