Review main Abandoned

89354[BUGFIX] Fixed UI inconsistency for CE wizard

Sven Liebert CR 0 V +1 Easy +21 −12 updated 08/24/25, 20:34

Commit message

Review

  • Code review CR 0
  • Verified V +1
    • Riccardo De Contardi +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 89

  1. Sven Liebert uploaded patch set 1 05/10/25, 16:23

  2. core-ci voted on patch set 1 V +1 05/10/25, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78756

  3. Riccardo De Contardi commented on patch set 1 V +1 05/10/25, 19:16

    tested on latest main
  4. Andreas Kienast commented on patch set 1 05/12/25, 13:56

    I wonder whether we shouldn't fix it the other way around – remove the "filter by" thingy in the Install Tool (and everywhere else). My reasoning for this is that a search input field with a proper placeholder gives enough context and doesn't require an "attachment" to it, telling a user what to do.
  5. Oli Bartsch commented on patch set 1 05/12/25, 13:58

    Reply

    +1 for removing this consistently in through the backend.
  6. Sven Liebert commented on patch set 1 05/12/25, 14:27

    Reply

    But from an accessibility perspective a label is needed which shouldn't be the placeholder. Any thoughts about that?
  7. Andreas Kienast commented on patch set 1 05/12/25, 14:34

    Reply Unresolved

    That's true. The point is that we currently don't use proper `<label>` tags here. Perhaps we may come up with a solution where labels may be used in a way they look like placeholders. I found this https://a11ymatters.com/pattern/accessible-search/ by a quick search but I cannot tell whether this is a good solution in A11Y terms.
  8. Riccardo De Contardi commented on patch set 1 05/12/25, 14:39

    for accessibility,you could also (see https://www.w3.org/WAI/tutorials/forms/labels/#associating-labels-explicitly) - hide the label - use aria-label
  9. Sven Liebert abandoned the change 08/24/25, 20:34