Review main Merged

89356[BUGFIX] Mitigate Postgres `like` type error for `JSON` fields

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 05/12/25, 08:42

Commit message

`EXT:lowlevel` provides the ability to search full records,
technically limited to all existing database table fields
limited to only TCA managed tables, already for a very long
time. Corresponding code contained special handling for the
PostgreSQL database platform adding field casting for `like`
queries to avoid PostgreSQL type conversion database errors.

Change #106657 introduced TCA configuration for `tx_scheduler_task`
containing native database json and `TCA type=json` fields added as
new storage format recently with #106532.

That lead to database errors with PostgresSQL within the
dbcheck module record search trying to simply use `like`
on json fields which is not supported.

The `Types::JSON` check to avoid adding type conversion for
Postgres for likes is now removed in two places and adding
conversion to `text` before doing a like search to mitigate
the aforementioned issue.

Note that `EXT:reactions` and `EXT:webhooks` are not active
in acceptance test setups. The json fields for TCA managed
tables of these extension has not been tested yet. That
explains why nightlies revealed that now for the scheduler
table and why the issue exists already since v12.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 1219

  1. Stefan Bürk uploaded patch set 1 05/11/25, 06:54

  2. core-ci voted on patch set 1 V +1 05/11/25, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78772

  3. core-ci commented on patch set 1 05/11/25, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78773

  4. Stefan Bürk updated the commit message in patch set 2 V +1 05/11/25, 11:38

  5. Stefan Bürk updated the commit message in patch set 3 05/11/25, 11:39

  6. Stefan Bürk updated the commit message in patch set 4 05/11/25, 11:43

  7. core-ci voted on patch set 2 V +1 05/11/25, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78775

  8. core-ci voted on patch set 3 V +1 05/11/25, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78776

  9. core-ci voted on patch set 4 V +1 05/11/25, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78777

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 05/11/25, 11:55

  11. Simon Schaufelberger updated the commit message in patch set 5 CR +1 V +1 05/11/25, 19:06

  12. core-ci voted on patch set 5 V +1 05/11/25, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78780

  13. Stefan Bürk updated the commit message in patch set 6 V +1 05/11/25, 19:58

  14. core-ci voted on patch set 6 V +1 05/11/25, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78781

  15. Simon Schaufelberger voted on patch set 6 CR +1 V +1 05/11/25, 20:06

  16. Anja Leichsenring voted on patch set 6 CR +1 V +1 05/12/25, 06:03

  17. Stefan Bürk voted on patch set 6 CR +2 V +2 05/12/25, 07:11

  18. Benni Mack voted on patch set 6 CR +1 05/12/25, 07:33

  19. Stefan Bürk merged patch set 7 05/12/25, 08:42