Review main Abandoned

89357[TASK] Provide clickable link in linkvalidator E-Mail report

Daniel Siepmann CR 0 V 0 Easy +1 −1 updated 05/14/25, 07:16

Commit message

Use an actual `a` Tag for broken URLs in HTML E-Mail of linkvalidator
report.
That way receivers of the E-Mail can actually work with the broken URL,
e.g. by copying or clicking on the link.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1317

  1. Daniel Siepmann uploaded patch set 1 05/12/25, 06:47

  2. Daniel Siepmann uploaded patch set 2 05/12/25, 06:48

  3. Daniel Siepmann uploaded patch set 3 05/12/25, 06:48

  4. core-ci voted on patch set 1 V +1 05/12/25, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78794

  5. core-ci voted on patch set 2 V +1 05/12/25, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78795

  6. core-ci voted on patch set 3 V +1 05/12/25, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78796

  7. Oliver Klee voted on patch set 3 CR +1 05/12/25, 08:10

  8. Andreas Kienast commented on patch set 3 CR -1 05/12/25, 13:28

    ValidatorTask.html:38

    Would we need `target="_blank"` and arguably `rel="noreferrer"` in case the mail is opened in a web mail client?
  9. Daniel Siepmann uploaded patch set 4 CR +1 V +1 05/13/25, 05:02

  10. Daniel Siepmann commented on patch set 4 05/13/25, 05:04

    ValidatorTask.html:38 Reply

    Good point. Not sure if we need it, but it does make sense from my perspective. Added in Patchset 4.
  11. core-ci voted on patch set 4 V +1 05/13/25, 05:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78829

  12. Oliver Klee voted on patch set 4 CR +1 05/13/25, 07:24

  13. Oli Bartsch commented on patch set 4 V -1 05/13/25, 08:08

    This does not work for internal links (type=db), e.g. for links in page content or file references.
  14. Oli Bartsch commented on patch set 4 05/13/25, 14:41

    Reply

    What do you think of instead adding a link to edit the record with the broken link? In LinkAnalyzerResult.php:229 ``` $brokenLink['edit_url'] = (string)$this->uriBuilder->buildUriFromRoute( 'record_edit', [ 'edit' => [ $brokenLink['table_name'] => [ $brokenLink['record_uid'] => 'edit', ], ], ], UriBuilder::SHAREABLE_URL ); ```
  15. Daniel Siepmann commented on patch set 4 05/13/25, 16:20

    Reply

    That doesn't work. TYPO3 doesn't know its own base in CLI context. We therefore won't be able to properly build the URL. At least I couldn't find a way to do so.
  16. Oli Bartsch commented on patch set 4 05/13/25, 20:06

    Reply Unresolved

    Ah yes, I think we could check the functionality in the PreviewUriBuilder, which is used for workspace notifications. However, the current solution does as mentioned, not work for internal links but now actually leads to broken links in the mail.
  17. Daniel Siepmann abandoned the change 05/14/25, 07:16

    Seems like there is no proper way right now to reach the goal