Review main Merged

89361[BUGFIX] Avoid "-" as first char of filename in mail spooler

Markus Klein CR +2 V +2 Easy +1 −1 updated 05/16/25, 09:58

Commit message

File names starting with a dash are a bit inconvenient
to handle on command lines.
Ease the life of admins by simply avoiding them.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Thomas Hohn +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1519

  1. Markus Klein uploaded patch set 1 05/12/25, 14:09

  2. Garvin Hicking commented on patch set 2 05/12/25, 14:15

    Published edit on patch set 1.
  3. Garvin Hicking voted on patch set 2 CR +1 05/12/25, 14:15

  4. core-ci voted on patch set 1 V +1 05/12/25, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78805

  5. Garvin Hicking commented on patch set 3 CR +1 05/12/25, 14:20

    Published edit on patch set 2.
  6. Garvin Hicking voted on patch set 3 CR +1 05/12/25, 14:20

  7. core-ci voted on patch set 2 V +1 05/12/25, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78807

  8. core-ci voted on patch set 3 V +1 05/12/25, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78808

  9. Andreas Kienast commented on patch set 3 CR -1 05/12/25, 14:27

    FileSpool.php:78

    IMO there is no guarantee that `$fileName[1]` isn't a dash as well, leading to the same issue.
  10. Garvin Hicking voted on patch set 3 CR 0 05/12/25, 14:32

  11. Markus Klein commented on patch set 3 05/12/25, 14:52

    FileSpool.php:78 Reply

    ;-) Agreed.
  12. Markus Klein uploaded patch set 4 CR -1 V +1 05/12/25, 15:10

  13. Markus Klein commented on patch set 4 05/12/25, 15:10

    FileSpool.php:78 Reply

    I did now, what I wanted to do initially.
  14. core-ci voted on patch set 4 V +1 05/12/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78810

  15. Thomas Hohn voted on patch set 4 CR +1 05/12/25, 17:23

  16. Oliver Klee voted on patch set 4 CR +1 05/13/25, 07:24

  17. Oli Bartsch voted on patch set 4 CR +1 V +1 05/13/25, 07:58

  18. Christian Kuhn voted on patch set 4 CR +2 V +2 05/16/25, 09:45

  19. Christian Kuhn merged patch set 5 05/16/25, 09:58