Review main Merged

89363[TASK] Update Fluid Standalone to 4.2.0

Simon Praetorius CR +2 V +2 Easy +11 −11 updated 05/21/25, 10:56

Commit message

Fluid 4.2.0 introduces argument definitions for Fluid templates,
which allows integrators to make their templates more reusable:
Each template, layout or partial can now specify its own API
(required variables, their types and default values for optional
variables) by using the new `<f:argument>` ViewHelper. These
argument definitions will be validated by a new
`StrictArgumentProcessor`, which will later also be used as a more
strict implementation for ViewHelpers.

Apart from this feature, the release contains multiple deprecations
in preparation for the next major release Fluid v5. In particular,
inherited ViewHelper namespaces now emit a deprecation notice
to the deprecation log. Inherited means that a ViewHelper namespace
is neither defined globally (in `TYPO3_CONF_VARS`) nor in the
template itself, but only in a parent template of a partial. This
currently prevents us from implementing reasonable cache warmups for
Fluid templates, which is why we will get rid of this rather obscure
feature with Fluid v5.

Currently, it is not possible to systematically find affected
templates, however this will be possible in the future, which is when
we will address these deprecations in TYPO3 Core.

Full release notes:
https://github.com/TYPO3/Fluid/releases/tag/4.2.0

Used commands:

> composer req typo3fluid/fluid:^4.2.0
> composer req -d typo3/sysext/adminpanel --no-update \
    typo3fluid/fluid:^4.2.0
> composer req -d typo3/sysext/core --no-update \
    typo3fluid/fluid:^4.2.0
> composer req -d typo3/sysext/fluid --no-update \
    typo3fluid/fluid:^4.2.0
> composer req -d typo3/sysext/redirects --no-update \
    typo3fluid/fluid:^4.2.0

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1522

  1. Simon Praetorius uploaded patch set 1 05/12/25, 16:43

  2. core-ci voted on patch set 1 V -1 05/12/25, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78816

  3. Simon Praetorius uploaded patch set 2 V -1 05/13/25, 20:36

  4. core-ci voted on patch set 2 V -1 05/13/25, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78870

  5. Simon Praetorius uploaded patch set 3 V -1 05/14/25, 13:51

  6. core-ci voted on patch set 3 V -1 05/14/25, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78915

  7. Simon Praetorius uploaded patch set 4 V -1 05/19/25, 08:22

  8. Simon Praetorius updated the commit message in patch set 5 05/19/25, 08:27

  9. core-ci voted on patch set 4 V -1 05/19/25, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79137

  10. core-ci voted on patch set 5 V -1 05/19/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79138

  11. Simon Praetorius updated the commit message in patch set 6 V -1 05/19/25, 09:34

  12. core-ci voted on patch set 6 V -1 05/19/25, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79146

  13. Simon Praetorius uploaded patch set 7 V -1 05/19/25, 11:28

  14. core-ci voted on patch set 7 V +1 05/19/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79160

  15. Simon Praetorius marked it ready for review 05/20/25, 16:19

  16. Benni Mack commented on patch set 7 05/20/25, 16:42

    fine by me, however, in v13.4 I would not use composer require but only composer update ... to use 4.2.0
  17. Simon Praetorius commented on patch set 7 05/20/25, 17:33

    Reply

    I think there was a similar discussion in 12.4. In the end, we returned to `composer require` to keep instances consistent and to be able to rely on newer Fluid in the Core. But both variants are fine by me.
  18. Benni Mack commented on patch set 7 CR +1 V +1 05/20/25, 19:14

    Reply

    yes. but I think I remember I regretted taking that decision (but I don't know why again, so fine with me - my brain isn't the final decision here). In this case, the main problem we have is that we might have version conflicts (low impact IMHO), but people cannot pin it down again if they run into problems. In addition: Introducing deprecations (that we have under control) in LTS versions is an imperfect situation. Both is fine for me.
  19. Christian Kuhn voted on patch set 7 CR +1 V +1 05/21/25, 10:07

  20. Simon Praetorius voted on patch set 7 CR +2 V +2 05/21/25, 10:15

  21. Simon Praetorius commented on patch set 7 05/21/25, 10:34

    Reply

    just for documentation: We agreed on require instead of update for v13, at least for this release.
  22. Simon Praetorius merged patch set 8 05/21/25, 10:56