Review main Merged

89371[BUGFIX] Ensure sudo-mode password field is autofocused

Benjamin Franzke CR +2 V +2 Easy +10 −11 updated 05/14/25, 09:26

Commit message

Use the `autofocus` HTML attribute to control auto focus
in modal elements and avoid the racy firstUpdate approach
that has been used before.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Thomas Hohn +1
    • Markus Klein +1
    • Sebastian Iffland +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Sebastian Iffland +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1112

  1. Benjamin Franzke uploaded patch set 1 05/13/25, 14:36

  2. core-ci voted on patch set 1 V +1 05/13/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78849

  3. Thomas Hohn voted on patch set 1 CR +1 05/13/25, 15:19

  4. Markus Klein commented on patch set 1 05/13/25, 15:23

    @ben@bnf.dev Can you please create the backports, so I can test v12.
  5. Sebastian Iffland voted on patch set 1 CR +1 V +1 05/13/25, 15:32

  6. Benjamin Franzke commented on patch set 1 05/13/25, 16:44

  7. Oliver Hader voted on patch set 1 CR +1 V +1 05/13/25, 20:45

  8. Andreas Kienast voted on patch set 1 CR +1 V +1 05/14/25, 06:23

  9. Markus Klein commented on patch set 1 05/14/25, 07:25

    Reply

    Thanks. Tested and voted
  10. Markus Klein voted on patch set 1 CR +1 V +1 05/14/25, 07:27

  11. Benni Mack voted on patch set 1 CR +2 V +2 05/14/25, 09:26

  12. Benni Mack merged patch set 2 05/14/25, 09:26