Review main Abandoned

89372[BUGFIX] Ensure non-absolute paths for AssetRenderer

Benni Mack CR +1 V +1 Hard +246 −11 updated 11/13/25, 21:27

Commit message

When using
<f:asset.css identifier="test" href="EXT:my_ext/Resources/Public/Css/foo.css" />
then the EXT: syntax is already resolved when calling
"AssetRenderer->getAbsoluteWebPath()" which would never
be transformed, as it is not prefixed
with "EXT:" nor is it prefixed with the Public Path.

This happened because "PathUtility::getAbsoluteWebPath()"
wasn't called anymore all the time with #104460.

Calling PathUtility::getAbsoluteWebPath() actually transforms
the vendor/my-vendor/my-extension/Resources/Public/Css/foo.css
to "/_assets/{hash}/Css/foo.css" which can then be prefixed
with the Public Path, then, thrown into
createVersionNumberedFilename().

As with the previous change, "PathUtility::getAbsoluteWebPath()"
is now called again at any time.

Review

  • Code review CR +1
    • Sebastian Iffland +1
  • Verified V +1
    • Sebastian Iffland +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 2836

Show 1011 earlier messages
  1. Benni Mack uploaded patch set 1 05/13/25, 14:54

  2. Markus Klein commented on patch set 1 05/13/25, 14:57

    "an absolute"
    can we maybe add this to the code as comment somehow? Just to make sure we are aware of all possible paths coming into that very function and that nobody kills this again in the future. What do you think?
  3. Markus Klein commented on patch set 1 05/13/25, 15:00

    AssetRenderer.php:132

    I'll push an update to this string concat only once. OK?
  4. core-ci voted on patch set 1 V +1 05/13/25, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78850

  5. Benni Mack commented on patch set 1 05/13/25, 15:01

    AssetRenderer.php:132 Reply

    go ahead
  6. Markus Klein uploaded patch set 2 V +1 05/13/25, 15:02

  7. Markus Klein commented on patch set 2 05/13/25, 15:02

    Reply

    Done

    AssetRenderer.php:132 Reply

    Done
  8. Markus Klein commented on patch set 2 05/13/25, 15:03

    AssetRenderer.php:132 Reply

    Done
  9. Sebastian Iffland voted on patch set 2 CR +1 05/13/25, 15:08

  10. Markus Klein commented on patch set 2 05/13/25, 15:08

    AssetRenderer.php:118

    Do we need to adjust things there as well?
  11. Sebastian Iffland voted on patch set 2 V +1 05/13/25, 15:08

  1. core-ci voted on patch set 2 V +1 05/13/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78856

  2. Markus Klein uploaded patch set 3 CR +1 V +1 05/13/25, 15:37

  3. Markus Klein uploaded patch set 4 05/13/25, 15:37

  4. Markus Klein commented on patch set 4 05/13/25, 15:39

    Still needs clarification regarding the PageRenderer method. Still could need some tests. The method in AssetRenderer has multiple calls to getAbsoluteWebPath and getFileAbsFileName (nested into other calls). Maybe an assessment if this all could be a bit simplified should be done.
  5. core-ci voted on patch set 3 V -1 05/13/25, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78858

  6. core-ci voted on patch set 4 V +1 05/13/25, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78859

  7. Sebastian Iffland voted on patch set 4 CR +1 05/13/25, 15:46

  8. Benni Mack uploaded patch set 5 CR +1 V +1 05/13/25, 21:30

  9. Benni Mack commented on patch set 5 05/13/25, 21:31

    Reply

    Done

    AssetRenderer.php:118 Reply

    nope. not for this regression fix, did not touch anything specific there.
  10. Benni Mack updated the commit message in patch set 6 05/13/25, 21:35

  11. core-ci voted on patch set 6 V +1 05/13/25, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78874

  12. core-ci voted on patch set 5 V +1 05/13/25, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78873

  13. Benni Mack uploaded patch set 7 V +1 05/13/25, 21:46

  14. core-ci voted on patch set 7 V +1 05/13/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78875

  15. Sebastian Iffland voted on patch set 7 CR +1 V +1 05/14/25, 08:19

  16. Markus Klein voted on patch set 7 CR +1 05/14/25, 08:48

  17. Markus Sommer voted on patch set 7 CR +1 V +1 05/14/25, 09:31

  18. Stefan Bürk voted on patch set 7 CR +1 V +1 05/14/25, 09:38

  19. Stefan Bürk voted on patch set 7 CR +2 V +2 05/14/25, 09:41

  20. Stefan Bürk voted on patch set 7 CR 0 V 0 05/14/25, 09:42

  21. Benni Mack uploaded patch set 8 CR +1 V +1 05/14/25, 09:55

  22. core-ci voted on patch set 8 V +1 05/14/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78900

  23. Sebastian Iffland commented on patch set 8 CR +1 V +1 05/14/25, 10:12

    LGTM
  24. Benni Mack marked it work in progress 05/14/25, 12:06

  25. Benni Mack abandoned the change 11/13/25, 21:27