89372[BUGFIX] Ensure non-absolute paths for AssetRenderer
Commit message
Review
-
Code review CR +1
- Sebastian Iffland +1
-
Verified V +1
- Sebastian Iffland +1
- core-ci +1 CI
Issues 2
Files 2
Review log 2836
Show 1011 earlier messages
-
Benni Mack uploaded patch set 1 05/13/25, 14:54
-
Markus Klein commented on patch set 1 05/13/25, 14:57
"an absolute"can we maybe add this to the code as comment somehow? Just to make sure we are aware of all possible paths coming into that very function and that nobody kills this again in the future. What do you think? -
Markus Klein commented on patch set 1 05/13/25, 15:00
AssetRenderer.php:132I'll push an update to this string concat only once. OK? -
core-ci voted on patch set 1 V +1 05/13/25, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78850
-
Benni Mack commented on patch set 1 05/13/25, 15:01
AssetRenderer.php:132Replygo ahead -
Markus Klein uploaded patch set 2
V +105/13/25, 15:02 -
Markus Klein commented on patch set 2 05/13/25, 15:03
AssetRenderer.php:132ReplyDone -
Sebastian Iffland voted on patch set 2 CR +1 05/13/25, 15:08
-
Markus Klein commented on patch set 2 05/13/25, 15:08
AssetRenderer.php:118Do we need to adjust things there as well? -
Sebastian Iffland voted on patch set 2 V +1 05/13/25, 15:08
-
core-ci voted on patch set 2 V +1 05/13/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78856
-
Markus Klein uploaded patch set 3
CR +1V +105/13/25, 15:37 -
Markus Klein uploaded patch set 4 05/13/25, 15:37
-
Markus Klein commented on patch set 4 05/13/25, 15:39
Still needs clarification regarding the PageRenderer method. Still could need some tests. The method in AssetRenderer has multiple calls to getAbsoluteWebPath and getFileAbsFileName (nested into other calls). Maybe an assessment if this all could be a bit simplified should be done. -
core-ci voted on patch set 3 V -1 05/13/25, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78858
-
core-ci voted on patch set 4 V +1 05/13/25, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78859
-
Sebastian Iffland voted on patch set 4 CR +1 05/13/25, 15:46
-
Benni Mack uploaded patch set 5
CR +1V +105/13/25, 21:30 -
Benni Mack commented on patch set 5 05/13/25, 21:31
Reply
DoneAssetRenderer.php:118Replynope. not for this regression fix, did not touch anything specific there. -
Benni Mack updated the commit message in patch set 6 05/13/25, 21:35
-
core-ci voted on patch set 6 V +1 05/13/25, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78874
-
core-ci voted on patch set 5 V +1 05/13/25, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78873
-
Benni Mack uploaded patch set 7
V +105/13/25, 21:46 -
core-ci voted on patch set 7 V +1 05/13/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78875
-
Sebastian Iffland voted on patch set 7 CR +1 V +1 05/14/25, 08:19
-
Markus Klein voted on patch set 7 CR +1 05/14/25, 08:48
-
Markus Sommer voted on patch set 7 CR +1 V +1 05/14/25, 09:31
-
Stefan Bürk voted on patch set 7 CR +1 V +1 05/14/25, 09:38
-
Stefan Bürk voted on patch set 7 CR +2 V +2 05/14/25, 09:41
-
Stefan Bürk voted on patch set 7 CR 0 V 0 05/14/25, 09:42
-
Benni Mack uploaded patch set 8
CR +1V +105/14/25, 09:55 -
core-ci voted on patch set 8 V +1 05/14/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78900
-
Sebastian Iffland commented on patch set 8 CR +1 V +1 05/14/25, 10:12
LGTM -
Benni Mack marked it work in progress 05/14/25, 12:06
-
Benni Mack abandoned the change 11/13/25, 21:27