Review 13.4 Merged

89374[BUGFIX] Address open_basedir issue in asset path handling

Simon Praetorius CR +2 V +2 Easy +2 −2 updated 05/13/25, 20:39

Commit message

With #105691, we addressed missing cache busting for absolute
file system paths. Unfortunately, this introduced a regression
if an open_basedir restriction is in effect. This patch fixes that
by ignoring any errors thrown by the introduced `file_exists()`
call. It also prevents duplicate slashes in the generated path.

Since the code isn't present in main anymore, this is only
relevant for 13.4 and 12.4 (original patch has been backported).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Thomas Hohn +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 912

  1. Simon Praetorius uploaded patch set 1 05/13/25, 14:57

  2. Simon Praetorius marked it ready for review 05/13/25, 14:58

  3. Benni Mack commented on patch set 2 05/13/25, 15:00

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 3 05/13/25, 15:00

    Published edit on patch set 2.
  5. Benni Mack voted on patch set 3 CR +1 V +1 05/13/25, 15:01

  6. core-ci voted on patch set 1 V +1 05/13/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78852

  7. core-ci voted on patch set 2 V +1 05/13/25, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78854

  8. core-ci voted on patch set 3 V +1 05/13/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78855

  9. Thomas Hohn voted on patch set 3 CR +1 05/13/25, 15:20

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 05/13/25, 16:11

  11. Benni Mack voted on patch set 3 CR +2 V +2 05/13/25, 20:39

  12. Benni Mack merged patch set 4 05/13/25, 20:39