Review 12.4 Merged

89378[BUGFIX] Ensure sudo-mode password field is autofocused

Benjamin Franzke CR +2 V +2 Easy +12 −13 updated 05/14/25, 09:27

Commit message

Use the `autofocus` HTML attribute to control auto focus
in modal elements and avoid the racy firstUpdate approach
that has been used before.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 56

  1. Benjamin Franzke uploaded patch set 1 05/13/25, 16:44

  2. core-ci voted on patch set 1 V +1 05/13/25, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78861

  3. Oliver Hader voted on patch set 1 CR +1 V +1 05/13/25, 20:50

  4. Markus Klein voted on patch set 1 CR +1 V +1 05/14/25, 07:21

  5. Benni Mack commented on patch set 1 CR +2 V +2 05/14/25, 09:27

    This change is ready for review.
  6. Benni Mack merged patch set 2 05/14/25, 09:27