Review main Merged

89381Revert "[BUGFIX] Strip only existing prefix in PathUtility::stripPathSitePrefix()"

Stefan Bürk CR +2 V +2 Normal +27 −54 updated 05/14/25, 09:20

Commit message

This reverts commit e5b30f1a3136a51ded87f65dea088ecb38081b22
as the bugfix revealed that quite a number of usages relied
at least partly on the behaviour, documented with #106690 and
a try to fix some of them [1] which did not pay out.

That gives us time to replace consuming places with suitable
replacements and drop the internal method in the end at all.

[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/89376

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Kevin Appelt +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Kevin Appelt +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Stefan Bürk uploaded patch set 1 05/14/25, 07:18

  2. Stefan Bürk updated the commit message in patch set 2 05/14/25, 07:18

  3. Stefan Bürk updated the commit message in patch set 3 05/14/25, 07:18

  4. core-ci voted on patch set 1 V +1 05/14/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78888

  5. core-ci voted on patch set 2 V +1 05/14/25, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78889

  6. core-ci voted on patch set 3 V +1 05/14/25, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78890

  7. Oliver Hader voted on patch set 3 CR +1 05/14/25, 07:42

  8. Markus Klein updated the commit message in patch set 4 CR +1 V +1 05/14/25, 07:45

  9. Markus Klein voted on patch set 4 CR +1 05/14/25, 07:45

  10. core-ci voted on patch set 4 V +1 05/14/25, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78895

  11. Kevin Appelt voted on patch set 4 CR +1 V +1 05/14/25, 08:45

  12. Benni Mack voted on patch set 4 CR +1 V +1 05/14/25, 09:16

  13. Stefan Bürk voted on patch set 4 CR +2 V +2 05/14/25, 09:20

  14. Stefan Bürk merged patch set 5 05/14/25, 09:20