89384[TASK] Avoid deserialization of undefined property in LazyObjectStorage
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1213
-
Oliver Hader uploaded patch set 1 05/14/25, 07:34
-
Benni Mack commented on patch set 1 05/14/25, 07:37
thank you! It would be good to have a tiny unit test for it (thus, any refactoring ensures that this is kept). And; Should we mark it as Bugfix? -
core-ci voted on patch set 1 V +1 05/14/25, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78894
-
Oliver Hader commented on patch set 1 05/14/25, 07:41
Reply
Marking it as `[BUGFIX]` would be fine. Do you see other test-cases that the new one in `LazyObjectStorageTest` I've added in the 1st patch-set? -
Benni Mack commented on patch set 1 CR +1 V +1 05/14/25, 07:56
yes. sry! -
Mathias Brodala commented on patch set 1 05/14/25, 07:59
What is the exact issue? The "undefined" mentioned here sounds like an example/placeholder. What property exactly was removed that could cause this? -
Oliver Klee voted on patch set 1 CR +1 05/14/25, 08:15
-
Oliver Hader commented on patch set 1 05/14/25, 08:27
Reply
`$undefined` is a placeholder for possible future refactoring or old serialized data that fiddled around with dynamic properties in user-land code. This change hardens deserialization to just use actually available properties. -
Mathias Brodala commented on patch set 1 05/14/25, 08:36
Reply
Acknowledged -
Simon Schaufelberger voted on patch set 1 CR +1 V +1 05/14/25, 09:16
-
Oli Bartsch voted on patch set 1 CR +1 V +1 05/14/25, 12:52
-
Oli Bartsch voted on patch set 1 CR +2 V +2 05/14/25, 12:53
-
Oli Bartsch merged patch set 2 05/14/25, 12:53