Review main Merged

89397[TASK] Extract filename pre-processing for uploaded files in FAL

Oliver Hader CR +2 V +2 Normal +76 −26 updated 05/15/25, 11:52

Commit message

TYPO3\CMS\Core\Resource\ResourceStorage::addUploadedFile hides
important pre-processing steps to resolve and sanitize the local
uploaded file path and the target file name.

Having the possibility to determine the actual file path and name
is beneficial for events to take actions before actually persisting
these files.

The pre-processing steps have been extracted into their own methods.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Frank Nägler +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Oliver Hader uploaded patch set 1 05/15/25, 07:36

  2. core-ci voted on patch set 1 V +1 05/15/25, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78949

  3. Andreas Kienast commented on patch set 1 05/15/25, 07:46

    processing

    ResourceStorage.php:1966

    We have this check trice now. Does it make sense to extract that into an `assertUploadedFileInstance()` (or alike)?
  4. Oliver Hader uploaded patch set 2 V +1 05/15/25, 07:59

  5. Oliver Hader commented on patch set 1 05/15/25, 08:00

    Reply

    Done

    ResourceStorage.php:1966 Reply

    Good idea 👍
  6. core-ci voted on patch set 2 V -1 05/15/25, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78950

  7. Oliver Hader uploaded patch set 3 V -1 05/15/25, 08:09

  8. core-ci voted on patch set 3 V +1 05/15/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78952

  9. Andreas Kienast voted on patch set 3 CR +1 V +1 05/15/25, 09:00

  10. Frank Nägler voted on patch set 3 CR +1 05/15/25, 10:12

  11. Frank Nägler voted on patch set 3 V +1 05/15/25, 10:22

  12. Oliver Hader voted on patch set 3 CR +2 V +2 05/15/25, 11:52

  13. Oliver Hader merged patch set 4 05/15/25, 11:52