89397[TASK] Extract filename pre-processing for uploaded files in FAL
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Frank Nägler +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oliver Hader +2
- Frank Nägler +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1013
-
Oliver Hader uploaded patch set 1 05/15/25, 07:36
-
core-ci voted on patch set 1 V +1 05/15/25, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78949
-
Andreas Kienast commented on patch set 1 05/15/25, 07:46
processingResourceStorage.php:1966We have this check trice now. Does it make sense to extract that into an `assertUploadedFileInstance()` (or alike)? -
Oliver Hader uploaded patch set 2
V +105/15/25, 07:59 -
Oliver Hader commented on patch set 1 05/15/25, 08:00
Reply
DoneResourceStorage.php:1966ReplyGood idea 👍 -
core-ci voted on patch set 2 V -1 05/15/25, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78950
-
Oliver Hader uploaded patch set 3
V -105/15/25, 08:09 -
core-ci voted on patch set 3 V +1 05/15/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78952
-
Andreas Kienast voted on patch set 3 CR +1 V +1 05/15/25, 09:00
-
Frank Nägler voted on patch set 3 CR +1 05/15/25, 10:12
-
Frank Nägler voted on patch set 3 V +1 05/15/25, 10:22
-
Oliver Hader voted on patch set 3 CR +2 V +2 05/15/25, 11:52
-
Oliver Hader merged patch set 4 05/15/25, 11:52