Review 13.4 Merged

89398[TASK] Extract filename pre-processing for uploaded files in FAL

Oliver Hader CR +2 V +2 Normal +76 −25 updated 05/15/25, 11:52

Commit message

TYPO3\CMS\Core\Resource\ResourceStorage::addUploadedFile hides
important pre-processing steps to resolve and sanitize the local
uploaded file path and the target file name.

Having the possibility to determine the actual file path and name
is beneficial for events to take actions before actually persisting
these files.

The pre-processing steps have been extracted into their own methods.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Oliver Hader uploaded patch set 1 05/15/25, 08:08

  2. Oliver Hader uploaded patch set 2 05/15/25, 08:09

  3. core-ci voted on patch set 1 V -1 05/15/25, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78951

  4. core-ci voted on patch set 2 V +1 05/15/25, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78953

  5. Oliver Hader voted on patch set 2 CR +2 V +2 05/15/25, 11:52

  6. Oliver Hader merged patch set 3 05/15/25, 11:52