Review main Merged

89400[BUGFIX] Fix local configuration GUI with numerical map keys

Garvin Hicking CR +2 V +2 Easy +11 −4 updated 05/20/25, 13:44

Commit message

The GUI-managed map/list local configuration handling introduced
with #106553 throws an exception when entering a numerical map
array key.

The "map" type is not yet utilized in the current TYPO3 core
DefaultConfiguration, thus this bug has no impact yet.

This patch adjusts the htmlentities() call to cast
numbers to a string to make numerical keys possible.

Note that later on, numerical array keys are actually
persisted with their proper numerical array key, not a string.

Also note that the GUI submits map keys sorted with
integer numbers first, and later handling also sorts
the whole array by their key.

To prevent the GUI from reporting multiple "Write configuration"
submits as having changes, the comparison of the old and
new values no longer report changes in sorting as a difference.
Only when values or keys change, the GUI reports it as a change.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Thomas Hohn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 911

  1. Garvin Hicking uploaded patch set 1 05/15/25, 08:31

  2. core-ci voted on patch set 1 V +1 05/15/25, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78955

  3. Garvin Hicking marked it work in progress 05/15/25, 10:10

  4. Garvin Hicking commented on patch set 2 V +1 05/15/25, 10:18

    Published edit on patch set 1.
  5. Garvin Hicking marked it ready for review 05/15/25, 10:18

  6. core-ci voted on patch set 2 V +1 05/15/25, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78960

  7. Georg Ringer voted on patch set 2 CR +1 V +1 05/19/25, 18:26

  8. Thomas Hohn voted on patch set 2 CR +1 05/19/25, 18:28

  9. Andreas Kienast voted on patch set 2 CR +1 V +1 05/20/25, 06:22

  10. Garvin Hicking voted on patch set 2 CR +2 V +2 05/20/25, 13:34

  11. Garvin Hicking merged patch set 3 05/20/25, 13:44