Review main Merged

89411[BUGFIX] Allow zero and blank string as valid type values

Georg Ringer CR +2 V +2 Normal +65 −6 updated 05/19/25, 06:39

Commit message

Adjusts the `array_filter` logic added in #94408 to allow
zero (`0`, `'0'`) and a blank string (`''`) as valid type value.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +2
    • Friedemann Altrock +1
    • Oliver Klee +1
    • Markus Sommer +1
    • Sebastian Iffland +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +2
    • Friedemann Altrock +1
    • Oliver Klee +1
    • Markus Sommer +1
    • Sebastian Iffland +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1820

  1. Georg Ringer uploaded patch set 1 05/15/25, 20:45

  2. Georg Ringer commented on patch set 1 05/15/25, 20:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/15/25, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79003

  4. Nikita Hovratov commented on patch set 1 05/15/25, 21:07

    DatabaseRecordTypeValue.php:158

    I guess this was primarily to remove empty strings, which are invalid type values? This should be kept at least.
  5. Oliver Hader commented on patch set 1 CR -1 05/15/25, 21:51

    on it
  6. Oliver Hader uploaded patch set 2 CR -1 V +1 05/15/25, 22:58

  7. Oliver Hader commented on patch set 2 05/15/25, 22:59

    DatabaseRecordTypeValue.php:158 Reply

    Done
  8. Oliver Hader commented on patch set 2 05/15/25, 23:02

    DatabaseRecordTypeValueTest.php:148

  9. core-ci voted on patch set 2 V +1 05/15/25, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79008

  10. Sebastian Iffland voted on patch set 2 V +1 05/16/25, 07:51

  11. Sebastian Iffland voted on patch set 2 CR +1 05/16/25, 07:51

  12. Markus Sommer voted on patch set 2 CR +1 V +1 05/16/25, 07:55

  13. Oliver Klee voted on patch set 2 CR +1 V +1 05/16/25, 08:17

  14. Christian Kuhn voted on patch set 2 CR +1 05/16/25, 09:11

  15. Friedemann Altrock voted on patch set 2 CR +1 V +1 05/19/25, 02:59

  16. Georg Ringer voted on patch set 2 CR +2 V +2 05/19/25, 06:18

  17. Oliver Hader voted on patch set 2 CR +1 V +1 05/19/25, 06:30

  18. Oliver Hader commented on patch set 2 05/19/25, 06:30

    Tested with ext:news as well...
  19. Oliver Hader voted on patch set 2 CR +2 V +2 05/19/25, 06:39

  20. Oliver Hader merged patch set 3 05/19/25, 06:39