89411[BUGFIX] Allow zero and blank string as valid type values
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Hader +2
- Friedemann Altrock +1
- Oliver Klee +1
- Markus Sommer +1
- Sebastian Iffland +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Hader +2
- Friedemann Altrock +1
- Oliver Klee +1
- Markus Sommer +1
- Sebastian Iffland +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1820
-
Georg Ringer uploaded patch set 1 05/15/25, 20:45
-
Georg Ringer commented on patch set 1 05/15/25, 20:45
This change is ready for review. -
core-ci voted on patch set 1 V +1 05/15/25, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79003
-
Nikita Hovratov commented on patch set 1 05/15/25, 21:07
DatabaseRecordTypeValue.php:158I guess this was primarily to remove empty strings, which are invalid type values? This should be kept at least. -
Oliver Hader commented on patch set 1 CR -1 05/15/25, 21:51
on it -
Oliver Hader uploaded patch set 2
CR -1V +105/15/25, 22:58 -
Oliver Hader commented on patch set 2 05/15/25, 22:59
DatabaseRecordTypeValue.php:158ReplyDone -
Oliver Hader commented on patch set 2 05/15/25, 23:02
DatabaseRecordTypeValueTest.php:148This changed seemed to be unnecessary in the previous change (https://review.typo3.org/c/Packages/TYPO3.CMS/+/69913/14/typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRecordTypeValueTest.php). Thus, I reverted it... -
core-ci voted on patch set 2 V +1 05/15/25, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79008
-
Sebastian Iffland voted on patch set 2 V +1 05/16/25, 07:51
-
Sebastian Iffland voted on patch set 2 CR +1 05/16/25, 07:51
-
Markus Sommer voted on patch set 2 CR +1 V +1 05/16/25, 07:55
-
Oliver Klee voted on patch set 2 CR +1 V +1 05/16/25, 08:17
-
Christian Kuhn voted on patch set 2 CR +1 05/16/25, 09:11
-
Friedemann Altrock voted on patch set 2 CR +1 V +1 05/19/25, 02:59
-
Georg Ringer voted on patch set 2 CR +2 V +2 05/19/25, 06:18
-
Oliver Hader voted on patch set 2 CR +1 V +1 05/19/25, 06:30
-
Oliver Hader commented on patch set 2 05/19/25, 06:30
Tested with ext:news as well... -
Oliver Hader voted on patch set 2 CR +2 V +2 05/19/25, 06:39
-
Oliver Hader merged patch set 3 05/19/25, 06:39