Review main Merged

89419[TASK] Use DI for LoadTcaService in UpgradeController

Oli Bartsch CR +2 V +2 Easy +3 −4 updated 05/16/25, 13:08

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Oli Bartsch uploaded patch set 1 05/16/25, 08:17

  2. core-ci voted on patch set 1 V -1 05/16/25, 08:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79030

  3. Christian Kuhn commented on patch set 1 05/16/25, 08:25

    UpgradeController.php:96

    above two are not stateless. we shouldn't inject them to not risk side effects. maybe a pre-patch to make them stateless, first?
  4. Christian Kuhn commented on patch set 1 CR -1 05/16/25, 08:28

    let's not continue injecting stateful stuff into otherwise stateless classes.
  5. Oli Bartsch uploaded patch set 2 CR -1 V -1 05/16/25, 08:46

  6. Oli Bartsch commented on patch set 2 05/16/25, 08:46

    UpgradeController.php:96 Reply

    Done
  7. core-ci voted on patch set 2 V +1 05/16/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79032

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 05/16/25, 09:10

  9. Nikita Hovratov voted on patch set 2 CR +1 V +1 05/16/25, 11:32

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 05/16/25, 13:08

  11. Oli Bartsch merged patch set 3 05/16/25, 13:08