89419[TASK] Use DI for LoadTcaService in UpgradeController
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Oli Bartsch uploaded patch set 1 05/16/25, 08:17
-
core-ci voted on patch set 1 V -1 05/16/25, 08:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79030
-
Christian Kuhn commented on patch set 1 05/16/25, 08:25
-
Christian Kuhn commented on patch set 1 CR -1 05/16/25, 08:28
let's not continue injecting stateful stuff into otherwise stateless classes. -
Oli Bartsch uploaded patch set 2
CR -1V -105/16/25, 08:46 -
Oli Bartsch commented on patch set 2 05/16/25, 08:46
UpgradeController.php:96ReplyDone -
core-ci voted on patch set 2 V +1 05/16/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79032
-
Christian Kuhn voted on patch set 2 CR +1 V +1 05/16/25, 09:10
-
Nikita Hovratov voted on patch set 2 CR +1 V +1 05/16/25, 11:32
-
Oli Bartsch voted on patch set 2 CR +2 V +2 05/16/25, 13:08
-
Oli Bartsch merged patch set 3 05/16/25, 13:08
UpgradeController.php:96