Review main Merged

89420[TASK] Apply CSP sandbox mode to fileadmin's .htaccess configuration

Oliver Hader CR +2 V +2 Normal +56 −2 updated 11/23/25, 09:46

Commit message

The directive `Content-Security-Policy: sandbox;` restricts
several client-side actions for files that may contain markup
(e.g., HTML, SVG):

* Disallows downloads
* Disallows form submissions
* Disallows modals and popups
* Disallows orientation and pointer lock
* Disallows presentation sessions
* Disallows navigation of the top-level browsing context

This applies only to resources located in the default file storage
location (e.g., `/fileadmin/`). Rendering Fluid templates from a
different location within the CMS application uses TYPO3's dynamic
CSP feature instead.

This change is considered a hardening and prevention measure.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1113

  1. Oliver Hader uploaded patch set 1 05/16/25, 08:29

  2. core-ci voted on patch set 1 V +1 05/16/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79031

  3. Torben Hansen voted on patch set 1 CR +1 V +1 05/16/25, 11:55

  4. Markus Klein voted on patch set 1 CR +1 V +1 05/16/25, 13:46

  5. Oliver Hader uploaded patch set 2 CR +1 V +1 05/19/25, 09:36

  6. Oliver Hader commented on patch set 2 05/19/25, 09:37

    I've added a RST file, instructing maintainers to manually adjust their configuration. Please revote. Thx :)
  7. core-ci voted on patch set 2 V +1 05/19/25, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79147

  8. Torben Hansen voted on patch set 2 CR +1 V +1 05/19/25, 10:15

  9. Markus Klein voted on patch set 2 CR +1 V +1 05/19/25, 12:41

  10. Oliver Hader voted on patch set 2 CR +2 V +2 05/19/25, 13:19

  11. Oliver Hader merged patch set 3 05/19/25, 13:20

  12. Stephan Großberndt commented on patch set 3 10/31/25, 09:10

    This change has 'Releases: main, 13.4, 12.4', but the backport to 12.4 is missing.
  13. Oliver Hader commented on patch set 3 11/23/25, 09:46

    Reply

    Thx. Indeed v12.4 has been forgotten.