Review main Merged

89421[TASK] Provide default icon for plugins

Nikita Hovratov CR +2 V +2 Easy +8 −6 updated 06/11/25, 07:36

Commit message

Since the synchronization of CType item groups and the wizard groups
all plugins appear in the "plugins" group of the
NewContentElementWizard. Since then, a lot of plugins appear without an
icon, because it wasn't really necessary to provide one for old
list_type plugins. This change adds a default generic plugin icon for
plugins registered in ExtensionUtility::registerPlugin.

The doc comment is adjusted to signalize that null is still a valid
value.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Nikita Hovratov uploaded patch set 1 05/16/25, 09:20

  2. core-ci voted on patch set 1 V -1 05/16/25, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79033

  3. Benni Mack commented on patch set 1 05/16/25, 09:35

    ExtensionUtility.php:118

    let's just go with the usage $pluginIcon ?? 'content-plugin' please.
  4. Nikita Hovratov uploaded patch set 2 V -1 05/16/25, 09:39

  5. Nikita Hovratov commented on patch set 2 05/16/25, 09:41

    ExtensionUtility.php:118 Reply

    Done
  6. core-ci voted on patch set 2 V +1 05/16/25, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79037

  7. Benni Mack voted on patch set 2 CR +1 V +1 05/16/25, 11:24

  8. Oli Bartsch commented on patch set 2 05/16/25, 13:40

    ExtensionUtility.php:132

    I suggest using `($pluginIcon ?? '') ?: 'content-plugin'`
  9. Nikita Hovratov commented on patch set 2 05/16/25, 13:54

    ExtensionUtility.php:132 Reply

    So you want an empty string to be treated like null? If someone passes an empty string to this method, this looks more like an error from the user side. In this case it is maybe better to display a broken icon so the user knows something is wrong.
  10. Benjamin Franzke commented on patch set 2 CR +1 V +1 06/03/25, 12:15

    ExtensionUtility.php:132 Reply

    I agree, checking for `null` is fine IMO, we should not "sanitize" the invalid value `''` here.
  11. Benjamin Franzke commented on patch set 2 CR +2 V +2 06/11/25, 06:47

    ExtensionUtility.php:132 Reply

    I'm going to merge now, I think we should be fine here (no counter-argument since some days)
  12. Benjamin Franzke merged patch set 3 06/11/25, 07:36