89421[TASK] Provide default icon for plugins
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1012
-
Nikita Hovratov uploaded patch set 1 05/16/25, 09:20
-
core-ci voted on patch set 1 V -1 05/16/25, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79033
-
Benni Mack commented on patch set 1 05/16/25, 09:35
-
Nikita Hovratov uploaded patch set 2
V -105/16/25, 09:39 -
Nikita Hovratov commented on patch set 2 05/16/25, 09:41
ExtensionUtility.php:118ReplyDone -
core-ci voted on patch set 2 V +1 05/16/25, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79037
-
Benni Mack voted on patch set 2 CR +1 V +1 05/16/25, 11:24
-
Oli Bartsch commented on patch set 2 05/16/25, 13:40
ExtensionUtility.php:132I suggest using `($pluginIcon ?? '') ?: 'content-plugin'` -
Nikita Hovratov commented on patch set 2 05/16/25, 13:54
ExtensionUtility.php:132ReplySo you want an empty string to be treated like null? If someone passes an empty string to this method, this looks more like an error from the user side. In this case it is maybe better to display a broken icon so the user knows something is wrong. -
Benjamin Franzke commented on patch set 2 CR +1 V +1 06/03/25, 12:15
ExtensionUtility.php:132ReplyI agree, checking for `null` is fine IMO, we should not "sanitize" the invalid value `''` here. -
Benjamin Franzke commented on patch set 2 CR +2 V +2 06/11/25, 06:47
ExtensionUtility.php:132ReplyI'm going to merge now, I think we should be fine here (no counter-argument since some days) -
Benjamin Franzke merged patch set 3 06/11/25, 07:36
ExtensionUtility.php:118