Review 13.4 Merged

89432[BUGFIX] Streamline DataHandler delete handling

Christian Kuhn CR +2 V +2 Hard +414 −512 updated 05/20/25, 11:08

Commit message

This is a bigger change to disentangle the delete handling
within DataHandler. The goal is to establish a more straight
call chain, to establish a cleaner entry method, to avoid
other parts of DataHandler misusing this code branch, to
improve performance by having the main BU::getRecord()
calls at fewer places and to have more centralized permission
checks.

We're also marking various quirky details with todo comments
to look at them with additional detail patches.

* Properly set record localization workspace overlays to
  deleted when deleting a workspace modified default
  language record.
* Add a missing access check when deleting modified workspace
  records.
* Method doesBranchExist() is renamed to getSubPagesOfPage(), only
  calculates sub page default language records and no longer checks
  permission details.
* Various methods get the full record hand over instead of
  fetching them over and over again.
* Method deleteAction() is now the public low level entry method
  to delete instead of deleteEl().
* Avoid property deletedRecords and its handling. It is useless
  with the better streamline logic.

The v13 backport will keep deleteEl() public.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 15

Review log 57

  1. Christian Kuhn uploaded patch set 1 05/16/25, 12:54

  2. Christian Kuhn commented on patch set 1 CR -2 05/16/25, 12:54

    the v13 backport will be delayed.
  3. core-ci voted on patch set 1 V -1 05/16/25, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79061

  4. Christian Kuhn uploaded patch set 2 V -1 05/16/25, 13:13

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. core-ci voted on patch set 2 V +1 05/16/25, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79064

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 05/20/25, 11:08

  7. Christian Kuhn merged patch set 3 05/20/25, 11:08