Review main Merged

89452[BUGFIX] Supply "element" argument to EXT:form partials

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 05/20/25, 13:45

Commit message

The partial "FrontendVersion2/Field/Required" uses an argument
"element", which is specified for the normal "Field" partials,
but is missing for the "AdvancedPassword" and "Checkbox" element
types.

That partial uses the "element" argument to refer to the CSS class
name for a required field, and will thus be empty when used for
these two types "AdvancedPassword" and "Checkbox".

In the previous "Frontend" version 1, the Required partial had
no arguments, so this missing argument is just an unintentional
adaptation mistake, and now fixed with this patch.

Configured CSS classes will now show up for "AdvancedPassword"
and "Checkbox" elements.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Tobias Jungmann +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Tobias Jungmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Garvin Hicking uploaded patch set 1 05/20/25, 08:35

  2. core-ci voted on patch set 1 V +1 05/20/25, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79199

  3. Tobias Jungmann voted on patch set 1 CR +1 V +1 05/20/25, 09:13

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 05/20/25, 09:49

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 05/20/25, 13:35

  6. Garvin Hicking merged patch set 2 05/20/25, 13:45