89471[BUGFIX] Recycler may hard-delete too much
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+79 −54
- typo3/sysext/core/Classes/Schema/Capability/LanguageAwareSchemaCapability.php+6 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/deleteThenRecreateThenHardDeleteLocalizedPage.csvnew+30 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/ActionTest.php+9 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php+20 −1
Review log 1216
-
Christian Kuhn uploaded patch set 1 05/20/25, 09:14
-
Christian Kuhn rebased onto patch set 2 05/20/25, 10:19
-
core-ci voted on patch set 2 V -1 05/20/25, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79227
-
Christian Kuhn uploaded patch set 3
V -105/20/25, 11:03 -
core-ci voted on patch set 3 V +1 05/20/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79231
-
Christian Kuhn uploaded patch set 4
V +105/20/25, 11:45 -
core-ci voted on patch set 4 V +1 05/20/25, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79235
-
Stefan Bürk commented on patch set 4 05/20/25, 12:35
Reviewing ... -
Stefan Bürk commented on patch set 4 05/20/25, 13:02
DataHandler.php:5473```suggestion // Restriction when hard deleting localized pages: Usually, localized records are hard deleted as well ``` -
Christian Kuhn commented on patch set 4 05/20/25, 13:14
DataHandler.php:5473ReplyDone -
Christian Kuhn uploaded patch set 5
V +105/20/25, 13:14 -
core-ci voted on patch set 5 V +1 05/20/25, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79240
-
Stefan Bürk commented on patch set 5 CR +1 V +1 05/20/25, 13:51
Reply
Done -
Benni Mack voted on patch set 5 CR +1 V +1 05/20/25, 15:21
-
Christian Kuhn voted on patch set 5 CR +2 V +2 05/20/25, 15:37
-
Christian Kuhn merged patch set 6 05/20/25, 15:37