89492[TASK] Update MimeTypeCollection for .csv => text/plain compatibility
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 3
Review log 1619
-
Garvin Hicking uploaded patch set 1 05/20/25, 21:11
-
core-ci voted on patch set 1 V +1 05/20/25, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79256
-
Garvin Hicking commented on patch set 1 V -1 05/20/25, 21:50
only preparation, I did not yet test this and if it fixes all of tbe reported issue. -
Albrecht Köhnlein commented on patch set 1 05/21/25, 06:13
MimeTypeCollection.php:938I guess, this line should be removed. -
Garvin Hicking commented on patch set 1 05/21/25, 06:19
MimeTypeCollection.php:938Replyif I understood correctly, some servers might actually use this mimetype, as this is also the "official" one to my understanding?! -
Albrecht Köhnlein commented on patch set 1 05/21/25, 06:23
MimeTypeCollection.php:938ReplyI guess, you're right https://www.rfc-editor.org/rfc/rfc4180 -
Oliver Hader uploaded patch set 2
V +105/21/25, 06:55 -
Oliver Hader commented on patch set 2 CR +1 V +1 05/21/25, 06:57
Tested with FAL Status in reports module. -
core-ci voted on patch set 2 V +1 05/21/25, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79272
-
Benjamin Franzke commented on patch set 2 05/21/25, 07:29
generateMimeTypes.php:37I kind of stumble over this comment: What refers "default" to here? I guess to the value that `finfo_file()`/`mime_content_type()` resolves (which is "text/plain")? But why do your refer to that as "default", is there something else than default? Also "Enhance" sounds wrong, is there a case where CSV is properly detected as `text/csv`? -
Albrecht Köhnlein commented on patch set 2 V +1 05/21/25, 07:39
Tested in TYPO3 13 and 12 and it works as expected -
Benjamin Franzke voted on patch set 2 V +1 05/21/25, 07:46
-
Oliver Hader commented on patch set 2 05/21/25, 07:48
generateMimeTypes.php:37ReplyGood point. I think this comment should be changed e.g. simply `allowing text/plain for cvs files as well`. Since CSV files don't have a proper file header, they always would be resolved to `text/plain`. However, when sending a file (in an HTTP response), using `text/csv` is more accurate. Thus, both types are fine, depending on the usage. -
Benjamin Franzke uploaded patch set 3
CR +1V +105/21/25, 08:12 -
core-ci voted on patch set 3 V +1 05/21/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79276
-
Garvin Hicking commented on patch set 3 05/21/25, 09:09
generateMimeTypes.php:37Reply Unresolvedthanks for these great improvements, lgtm! -
Garvin Hicking commented on patch set 3 V -1 05/21/25, 09:38
Unresolved
see comments in https://forge.typo3.org/issues/106735#change-543454 - I think we'll need to address more MIME dupes?! -
Benjamin Franzke voted on patch set 3 CR 0 V 0 05/22/25, 07:24
-
Garvin Hicking abandoned the change 05/23/25, 06:39
I think this is not a good approach and would need way too many entries. We should move forward with alternate approaches that are being investigated. thus, closing this for now.