Review main Merged

89494[BUGFIX] Allow file abstraction layer to process uppercase file names

Oliver Hader CR +2 V +2 Easy +15 −4 updated 05/22/25, 09:24

Commit message

Processing a file with the name `image.PNG` fails due to the lack
of normalizing the file extension in ResourceConsistencyService.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1416

  1. Oliver Hader uploaded patch set 1 05/21/25, 08:51

  2. core-ci voted on patch set 1 V +1 05/21/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79281

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 05/21/25, 09:41

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 05/21/25, 09:52

  5. Garvin Hicking commented on patch set 1 05/21/25, 09:54

    are there any umlaut file extensions so we should use mb_strtolower I just ask myseld?
  6. Albrecht Köhnlein commented on patch set 1 05/21/25, 11:05

  7. Albrecht Köhnlein commented on patch set 1 05/21/25, 11:24

    Reply

    Sorry - you asked for umlaut extensions. I did not find one. But who knows if there will be any at any time? So I think, there is no reason why not to use mb_strtolower()
  8. Christian Kuhn commented on patch set 1 05/21/25, 11:57

    Reply

    agreed. mb_strtolower() would be a more safe solution.
  9. Oliver Hader commented on patch set 2 CR +1 V +1 05/22/25, 08:38

    Published edit on patch set 1.
  10. Oliver Hader commented on patch set 2 05/22/25, 08:39

    Reply

    Done
  11. core-ci voted on patch set 2 V +1 05/22/25, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79354

  12. Benni Mack voted on patch set 2 CR +1 V +1 05/22/25, 08:50

  13. Christian Kuhn voted on patch set 2 CR +1 V +1 05/22/25, 08:58

  14. Garvin Hicking voted on patch set 2 CR +1 V +1 05/22/25, 09:06

  15. Oliver Hader voted on patch set 2 CR +2 V +2 05/22/25, 09:24

  16. Oliver Hader merged patch set 3 05/22/25, 09:24