89494[BUGFIX] Allow file abstraction layer to process uppercase file names
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1416
-
Oliver Hader uploaded patch set 1 05/21/25, 08:51
-
core-ci voted on patch set 1 V +1 05/21/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79281
-
Garvin Hicking voted on patch set 1 CR +1 V +1 05/21/25, 09:41
-
Christian Kuhn voted on patch set 1 CR +1 V +1 05/21/25, 09:52
-
Garvin Hicking commented on patch set 1 05/21/25, 09:54
are there any umlaut file extensions so we should use mb_strtolower I just ask myseld? -
Albrecht Köhnlein commented on patch set 1 05/21/25, 11:05
Reply
Seems so: https://stackoverflow.com/questions/68589982/are-there-any-real-file-types-with-non-ascii-file-extensions Maybe there will be more in the future. -
Albrecht Köhnlein commented on patch set 1 05/21/25, 11:24
Reply
Sorry - you asked for umlaut extensions. I did not find one. But who knows if there will be any at any time? So I think, there is no reason why not to use mb_strtolower() -
Christian Kuhn commented on patch set 1 05/21/25, 11:57
Reply
agreed. mb_strtolower() would be a more safe solution. -
Oliver Hader commented on patch set 2
CR +1V +105/22/25, 08:38Published edit on patch set 1. -
Oliver Hader commented on patch set 2 05/22/25, 08:39
Reply
Done -
core-ci voted on patch set 2 V +1 05/22/25, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79354
-
Benni Mack voted on patch set 2 CR +1 V +1 05/22/25, 08:50
-
Christian Kuhn voted on patch set 2 CR +1 V +1 05/22/25, 08:58
-
Garvin Hicking voted on patch set 2 CR +1 V +1 05/22/25, 09:06
-
Oliver Hader voted on patch set 2 CR +2 V +2 05/22/25, 09:24
-
Oliver Hader merged patch set 3 05/22/25, 09:24