Review main Merged

89495[TASK] Clean up EXT:scheduler

Benni Mack CR +2 V +2 Expert +221 −1623 updated 06/02/25, 15:22

Commit message

All code related to custom editing and adding
of scheduler tasks can now be removed as it is unused.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 28

Show 8 more files

Review log 2131

Show 46 earlier messages
  1. Benni Mack uploaded patch set 1 05/21/25, 09:21

  2. core-ci voted on patch set 1 V -1 05/21/25, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79286

  3. Benni Mack marked it work in progress 05/21/25, 09:38

  4. Benni Mack uploaded patch set 2 V -1 05/21/25, 09:48

  5. core-ci voted on patch set 2 V -1 05/21/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79289

  6. Benni Mack uploaded patch set 3 V -1 05/27/25, 11:47

  1. core-ci voted on patch set 3 V -1 05/27/25, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79560

  2. Benni Mack uploaded patch set 4 V -1 05/27/25, 12:00

  3. Benni Mack marked it ready for review 05/27/25, 12:01

  4. core-ci voted on patch set 4 V +1 05/27/25, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79564

  5. Christian Kuhn commented on patch set 4 05/27/25, 13:45

    SchedulerModuleController.php:71

    maybe we could adapt that comment.

    SchedulerTaskRepository.php:45

    let's inline that state to the single place that uses it to free the constructor body and have a stateless class. mark the class readonly.

    SchedulerTaskRepository.php:132

    can be substituted with BU::getRecord()

    SchedulerTaskRepository.php:175

    this part is identical to findRecordByUid()?

    SchedulerTaskRepository.php:448

    smells like another BU::getRecord call?

    Execution.php:211

    sounds funny in my ears. maybe isParallelExecutionAllowed() to avoid the double plural?
  6. Benni Mack uploaded patch set 5 V +1 05/27/25, 14:22

  7. Benni Mack uploaded patch set 6 05/27/25, 14:26

  8. core-ci voted on patch set 5 V -1 05/27/25, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79579

  9. core-ci voted on patch set 6 V -1 05/27/25, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79580

  10. Benni Mack uploaded patch set 7 V -1 05/28/25, 09:20

  11. core-ci voted on patch set 7 V -1 05/28/25, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79620

  12. Benni Mack uploaded patch set 8 V -1 06/02/25, 10:53

  13. Benni Mack commented on patch set 8 06/02/25, 10:53

    SchedulerModuleController.php:71 Reply

    Done

    SchedulerTaskRepository.php:45 Reply

    Done

    SchedulerTaskRepository.php:132 Reply

    Done

    SchedulerTaskRepository.php:175 Reply

    Done

    SchedulerTaskRepository.php:448 Reply

    Done

    Execution.php:211 Reply

    Done
  14. core-ci voted on patch set 8 V +1 06/02/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79743

  15. Stefan Bürk commented on patch set 8 06/02/25, 12:18

    Execution.php:211 Reply

    Do we really need a new duplicated method of `getMultiple()` ? Maybe we should simply replace getMultiple() with the new one than .. class is internal. Or is there a use-case to have both returningthe same I'm overseeing here ?
  16. Benni Mack commented on patch set 8 06/02/25, 12:19

    Execution.php:211 Reply

    nope. We can remove getMultiple(), but we cannot rename the property (yet) due to the unserialize logic we keep until the upgrade wizard is gone. TBH: It was VERY confusing for me to understand what "Execution->getMultiple()" means - that's why I renamed it.
  17. Benni Mack uploaded patch set 9 V +1 06/02/25, 12:55

  18. Benni Mack commented on patch set 9 06/02/25, 12:57

    Execution.php:211 Reply

    Done
  19. core-ci voted on patch set 9 V +1 06/02/25, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79753

  20. Georg Ringer uploaded patch set 10 V +1 06/02/25, 13:34

  21. Georg Ringer voted on patch set 10 CR +1 V +1 06/02/25, 13:36

  22. core-ci voted on patch set 10 V +1 06/02/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79755

  23. Stefan Bürk voted on patch set 10 CR +1 V +1 06/02/25, 15:08

  24. Benni Mack voted on patch set 10 CR +2 V +2 06/02/25, 15:22

  25. Benni Mack merged patch set 11 06/02/25, 15:22