89495[TASK] Clean up EXT:scheduler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 28
- Build/phpstan/phpstan-baseline.neon+0 −12
- Build/Sources/Sass/module/_scheduler.scss+0 −8
- Build/Sources/TypeScript/scheduler/scheduler.ts+0 −356
- typo3/sysext/backend/Resources/Public/Css/backend.css+0 −2
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+0 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php2+17 −486
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php8+22 −109
- typo3/sysext/scheduler/Classes/Form/Element/TimingOptionsElement.php+1 −1
- typo3/sysext/scheduler/Classes/Hooks/SchedulerTaskPersistenceValidator.php+1 −2
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+0 −33
- typo3/sysext/scheduler/Classes/Execution.php5+7 −7
- typo3/sysext/scheduler/Classes/Scheduler.php+1 −1
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+0 −21
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditAdditionalFields.htmldeleted+0 −174
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditDescriptionField.htmldeleted+0 −17
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditDisableField.htmldeleted+0 −20
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditFrequencyField.htmldeleted+0 −29
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditMultipleField.htmldeleted+0 −20
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditStartEndFields.htmldeleted+0 −70
Show 8 more files
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditTaskGroupField.htmldeleted+0 −37
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditTypeField.htmldeleted+0 −26
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+2 −2
- typo3/sysext/scheduler/Resources/Private/Templates/AdditionalFields.html+167 −1
- typo3/sysext/scheduler/Resources/Private/Templates/AddTaskForm.htmldeleted+0 −95
- typo3/sysext/scheduler/Resources/Private/Templates/EditTaskForm.htmldeleted+0 −89
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler.js+1 −1
- typo3/sysext/scheduler/Tests/Unit/Validation/Validator/TaskValidatorTest.php+1 −1
Review log 2131
Show 46 earlier messages
-
Benni Mack uploaded patch set 1 05/21/25, 09:21
-
core-ci voted on patch set 1 V -1 05/21/25, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79286
-
Benni Mack marked it work in progress 05/21/25, 09:38
-
Benni Mack uploaded patch set 2
V -105/21/25, 09:48 -
core-ci voted on patch set 2 V -1 05/21/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79289
-
Benni Mack uploaded patch set 3
V -105/27/25, 11:47
-
core-ci voted on patch set 3 V -1 05/27/25, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79560
-
Benni Mack uploaded patch set 4
V -105/27/25, 12:00 -
Benni Mack marked it ready for review 05/27/25, 12:01
-
core-ci voted on patch set 4 V +1 05/27/25, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79564
-
Christian Kuhn commented on patch set 4 05/27/25, 13:45
SchedulerTaskRepository.php:45let's inline that state to the single place that uses it to free the constructor body and have a stateless class. mark the class readonly.SchedulerTaskRepository.php:132can be substituted with BU::getRecord()SchedulerTaskRepository.php:175this part is identical to findRecordByUid()?SchedulerTaskRepository.php:448smells like another BU::getRecord call?Execution.php:211sounds funny in my ears. maybe isParallelExecutionAllowed() to avoid the double plural? -
Benni Mack uploaded patch set 5
V +105/27/25, 14:22 -
Benni Mack uploaded patch set 6 05/27/25, 14:26
-
core-ci voted on patch set 5 V -1 05/27/25, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79579
-
core-ci voted on patch set 6 V -1 05/27/25, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79580
-
Benni Mack uploaded patch set 7
V -105/28/25, 09:20 -
core-ci voted on patch set 7 V -1 05/28/25, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79620
-
Benni Mack uploaded patch set 8
V -106/02/25, 10:53 -
Benni Mack commented on patch set 8 06/02/25, 10:53
SchedulerModuleController.php:71ReplyDoneSchedulerTaskRepository.php:45ReplyDoneSchedulerTaskRepository.php:132ReplyDoneSchedulerTaskRepository.php:175ReplyDoneSchedulerTaskRepository.php:448ReplyDoneExecution.php:211ReplyDone -
core-ci voted on patch set 8 V +1 06/02/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79743
-
Stefan Bürk commented on patch set 8 06/02/25, 12:18
Execution.php:211ReplyDo we really need a new duplicated method of `getMultiple()` ? Maybe we should simply replace getMultiple() with the new one than .. class is internal. Or is there a use-case to have both returningthe same I'm overseeing here ? -
Benni Mack commented on patch set 8 06/02/25, 12:19
Execution.php:211Replynope. We can remove getMultiple(), but we cannot rename the property (yet) due to the unserialize logic we keep until the upgrade wizard is gone. TBH: It was VERY confusing for me to understand what "Execution->getMultiple()" means - that's why I renamed it. -
Benni Mack uploaded patch set 9
V +106/02/25, 12:55 -
Benni Mack commented on patch set 9 06/02/25, 12:57
Execution.php:211ReplyDone -
core-ci voted on patch set 9 V +1 06/02/25, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79753
-
Georg Ringer uploaded patch set 10
V +106/02/25, 13:34 -
Georg Ringer voted on patch set 10 CR +1 V +1 06/02/25, 13:36
-
core-ci voted on patch set 10 V +1 06/02/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79755
-
Stefan Bürk voted on patch set 10 CR +1 V +1 06/02/25, 15:08
-
Benni Mack voted on patch set 10 CR +2 V +2 06/02/25, 15:22
-
Benni Mack merged patch set 11 06/02/25, 15:22
SchedulerModuleController.php:71