Review main Merged

89503[TASK] Remove entrypoint "typo3/install.php"

Benni Mack CR +2 V +2 Hard +148 −130 updated 09/25/25, 11:44

Commit message

This change removes the separate entrypoint
"typo3/install.php" from TYPO3 Core.

Instead, the Install Tool is now routed to
the TYPO3 Backend system instead of the file
"/typo3/install.php", so it follows the
$GLOBALS[TYPO3_CONF_VARS][BE][entryPoint] option,
and the maintenance mode can then be available
in other locations - appending /install.

If the system is not set up properly - or
no .htaccess / rewrite rules - the GET variable
"__typo3_install" is used to access the install
tool directly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 28

Show 8 more files

Review log 2741

Show 1016 earlier messages
  1. Benni Mack uploaded patch set 1 05/21/25, 15:08

  2. Benni Mack uploaded patch set 2 05/21/25, 15:09

  3. Benni Mack marked it work in progress 05/21/25, 15:09

  4. core-ci voted on patch set 1 V -1 05/21/25, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79320

  5. core-ci voted on patch set 2 V -1 05/21/25, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79321

  6. Benni Mack uploaded patch set 3 V -1 05/21/25, 15:43

  7. core-ci voted on patch set 3 V -1 05/21/25, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79323

  8. Mathias Brodala commented on patch set 3 05/22/25, 06:03

    index.php:20

    Is this meant to cover installations in subdirectories? Otherwise this should be str_begins_with(). Else any path containing "/typo3/install.php" would lead to the install tool, e.g. "https://example.org/some/page/typo3/install.php";
  9. Benni Mack commented on patch set 3 06/11/25, 17:02

    index.php:20 Reply

    This is meant to be a PoC. An example that it is possible to make this work at all, which is currently really hard to achieve, and some people doubt that "this is not possible".
  10. Benni Mack uploaded patch set 4 V -1 07/29/25, 10:38

  11. core-ci voted on patch set 4 V -1 07/29/25, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82482

  12. Benni Mack uploaded patch set 5 V -1 09/22/25, 15:53

  13. core-ci voted on patch set 5 V -1 09/22/25, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85315

  14. Benni Mack uploaded patch set 6 V -1 09/22/25, 19:47

  15. Benni Mack uploaded patch set 7 09/22/25, 19:56

  16. core-ci voted on patch set 6 V -1 09/22/25, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85340

  1. core-ci voted on patch set 7 V -1 09/22/25, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85344

  2. Benjamin Franzke uploaded patch set 8 V -1 09/25/25, 07:25

  3. core-ci voted on patch set 8 V -1 09/25/25, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85482

  4. Benjamin Franzke uploaded patch set 9 V -1 09/25/25, 07:42

  5. core-ci voted on patch set 9 V +1 09/25/25, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85483

  6. Benjamin Franzke uploaded patch set 10 V +1 09/25/25, 07:54

  7. Benjamin Franzke commented on patch set 10 09/25/25, 07:54

    index.php:20 Reply

    Solved by using a GET parameter that does not need to care about possible subdirectory installations (works in subdirectory installation now).
  8. core-ci voted on patch set 10 V +1 09/25/25, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85484

  9. Benjamin Franzke uploaded patch set 11 V +1 09/25/25, 08:31

  10. core-ci voted on patch set 11 V +1 09/25/25, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85490

  11. Benni Mack uploaded patch set 12 V +1 09/25/25, 10:10

  12. Benni Mack uploaded patch set 13 09/25/25, 10:13

  13. Benni Mack marked it ready for review 09/25/25, 10:13

  14. Benjamin Franzke voted on patch set 13 CR +1 V +1 09/25/25, 10:17

  15. core-ci voted on patch set 12 V +1 09/25/25, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85498

  16. Benni Mack updated the commit message in patch set 14 CR +1 V +1 09/25/25, 10:22

  17. core-ci voted on patch set 13 V +1 09/25/25, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85499

  18. Benjamin Franzke voted on patch set 14 CR +1 V +1 09/25/25, 10:25

  19. core-ci voted on patch set 14 V +1 09/25/25, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85500

  20. Christian Kuhn voted on patch set 14 CR +1 V +1 09/25/25, 10:47

  21. Benni Mack commented on patch set 14 CR +2 V +2 09/25/25, 11:20

    thanks. this will be the beginning of the end (for the typo3/ directory). We now only have one web entry point!
  22. Benni Mack merged patch set 15 09/25/25, 11:20

  23. Stefan Bürk commented on patch set 15 09/25/25, 11:31

    Reply

    Not the end for that folder in `classic mode` instances until spoort for that dropped (not on the table). That mode still provides the system extension in that folder ;).
  24. Benjamin Franzke commented on patch set 15 09/25/25, 11:35

    Reply

    > Not the end for that folder in classic mode instances until spoort ack. btw, that has been in the TODOs until patchset 10: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89503/10//COMMIT_MSG#16 That's why it's "the beginning of the end" and not yet the end ;)
  25. Benni Mack commented on patch set 15 09/25/25, 11:44

    Reply

    removeal of classic mode is "not on the table", however, I strongly believe classic mode in v14 might work without a typo3/ directory - that's what I meant with my comment!