Review main Merged

89514[TASK] Enable configurable form name in SettingsEditor

Benjamin Kott CR +2 V +2 Easy +5 −3 updated 05/28/25, 09:35

Commit message

Allows setting a custom form name in the
SettingsEditor to support multiple instances.
The form name facilitates interaction with
external elements, such as a submit button in the
docheader, improving flexibility and usability.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1116

  1. Benjamin Kott uploaded patch set 1 05/23/25, 07:11

  2. core-ci voted on patch set 1 V +1 05/23/25, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79408

  3. Benjamin Franzke commented on patch set 1 05/23/25, 07:37

    editor.ts:301

    nitpick: ``` id=${this.formName} ```
  4. Benjamin Franzke uploaded patch set 2 V +1 05/23/25, 08:28

  5. Benjamin Franzke commented on patch set 2 05/23/25, 08:28

    editor.ts:301 Reply

    Done
  6. core-ci voted on patch set 2 V +1 05/23/25, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79413

  7. Benjamin Kott uploaded patch set 3 CR +1 V +1 05/27/25, 11:11

  8. core-ci voted on patch set 3 V +1 05/27/25, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79558

  9. Benjamin Kott marked it ready for review 05/27/25, 12:13

  10. Benjamin Franzke uploaded patch set 4 V +1 05/28/25, 08:00

  11. core-ci voted on patch set 4 V +1 05/28/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79607

  12. Benjamin Franzke uploaded patch set 5 V +1 05/28/25, 09:02

  13. core-ci voted on patch set 5 V +1 05/28/25, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79617

  14. Benni Mack voted on patch set 5 CR +1 V +1 05/28/25, 09:18

  15. Benjamin Franzke voted on patch set 5 CR +2 V +2 05/28/25, 09:25

  16. Benjamin Franzke merged patch set 6 05/28/25, 09:35