89516[TASK] Refactor settings editor to support user-level advanced mode
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/backend/settings/editor/editable-setting.ts+22 −21
- Build/Sources/TypeScript/backend/settings/enum/settings-mode.enum.tsnew+23 −0
- Build/Sources/TypeScript/backend/settings/editor.ts+3 −3
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.php2+70 −11
- typo3/sysext/backend/Resources/Private/Language/locallang_settingseditor.xlfnew+14 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Edit.html+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor/editable-setting.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/enum/settings-mode.enum.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor.js+1 −1
- typo3/sysext/core/Classes/Settings/SettingsMode.phpnew+27 −0
Review log 2536
Show 611 earlier messages
-
Benjamin Kott uploaded patch set 1 05/23/25, 11:36
-
core-ci voted on patch set 1 V -1 05/23/25, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79420
-
Benjamin Kott uploaded patch set 2
V -105/23/25, 11:56 -
core-ci voted on patch set 2 V -1 05/23/25, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79422
-
Benjamin Kott uploaded patch set 3
V -105/23/25, 12:08 -
core-ci voted on patch set 3 V +1 05/23/25, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79424
-
Benjamin Kott updated the commit message in patch set 4
V +105/23/25, 12:25 -
Benjamin Kott updated the commit message in patch set 5 05/23/25, 12:26
-
Benjamin Kott updated the commit message in patch set 6 05/23/25, 12:26
-
core-ci voted on patch set 4 V +1 05/23/25, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79426
-
core-ci voted on patch set 5 V +1 05/23/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79427
-
core-ci voted on patch set 6 V +1 05/23/25, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79428
-
Benjamin Kott voted on patch set 6 CR -1 05/27/25, 06:44
-
Benjamin Kott uploaded patch set 7
CR -1V +105/27/25, 07:10 -
core-ci voted on patch set 7 V +1 05/27/25, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79544
-
Benjamin Kott uploaded patch set 8
V +105/27/25, 07:35 -
core-ci voted on patch set 8 V +1 05/27/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79547
-
Benjamin Kott rebased onto patch set 9
V +105/27/25, 11:11 -
Benni Mack voted on patch set 9 CR +1 V +1 05/27/25, 11:12
-
core-ci voted on patch set 9 V +1 05/27/25, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79556
-
Benjamin Franzke commented on patch set 9 V +1 05/28/25, 07:17
I'm not exactly sure why you classify this as a bugfix, TASK would be better, no? I mean it's an improvement, yes.SiteSettingsController.php:173Can now be removed. -
Garvin Hicking commented on patch set 9 05/28/25, 07:36
IMO we should also include an Important.rst to tell people who used the debug mode before how to change this. This would also allow the documentation team to act on updating the documentation on how to enable/toggle this. -
Benjamin Franzke commented on patch set 9 05/28/25, 07:38
Reply
Hm, what exactly has been documented? Can you provide a link? -
Benjamin Franzke uploaded patch set 10
CR +1V +105/28/25, 07:44 -
Benjamin Franzke commented on patch set 10 05/28/25, 07:44
Reply
DoneSiteSettingsController.php:173ReplyDone -
Benjamin Franzke commented on patch set 10 05/28/25, 07:47
Reply
Context: I'd like to avoid flooding our users with Important.rst with not sooo important information, you know what I mean? I'd prefer if we could signal this between our teams directly and without an RST, if that's fine and if there is sth. to be updated. Do you agree? -
core-ci voted on patch set 10 V +1 05/28/25, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79603
-
Benjamin Kott commented on patch set 10 05/28/25, 08:03
Reply
Until now, it was a "dirty" hack, that slipped in due to time constraints. I cannot find any documentation about this. -
Garvin Hicking commented on patch set 10 05/28/25, 08:39
Reply
I thought I had seen something like that but am lacking the time (and proper keywords) to find it. Might be that I just remember the usual "[debug]" settings possibilities in FormEngine. However IMO this new UI change to me is similar to a new feature and I think it's a nice one, and should be advertised to end-users. But feel free to ignore this, non-blocking. -
Benjamin Franzke rebased onto patch set 11
CR +1V +105/28/25, 08:59 -
Benjamin Kott commented on patch set 11 05/28/25, 09:01
Reply
If you already tested it and think it´s fine - just vote 😅. -
core-ci voted on patch set 11 V +1 05/28/25, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79615
-
Benni Mack voted on patch set 11 CR +1 V +1 05/28/25, 09:15
-
Benni Mack commented on patch set 11 05/28/25, 09:15
Reply
I think we're OK as it is. -
Benjamin Kott voted on patch set 11 CR +2 V +2 05/28/25, 09:33
-
Benjamin Kott merged patch set 12 05/28/25, 09:33