Review main Merged

89522[TASK] Migrate various places in TYPO3 to Schema API

Benni Mack CR +2 V +2 Hard +177 −97 updated 06/04/25, 16:23

Commit message

This change touches several minor changes
in TYPO3 to use Schema API.

Further leftover places:
- BackendUtility (will be replaced via new APIs)
- EXT:install SessionService (todo)
- DefaultTcaSchema (separate patch)
- FormEngine
- Icon API (coupled to FormEngine)

as FormEngine is also used for non-TCA
parts, this needs to be used with a similar
API ("MutableSchemaAPI" ?).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1725

  1. Benni Mack uploaded patch set 1 05/26/25, 10:34

  2. Benni Mack rebased onto patch set 2 05/26/25, 10:43

  3. core-ci voted on patch set 1 V -1 05/26/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79479

  4. core-ci voted on patch set 2 V -1 05/26/25, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79481

  5. Benni Mack uploaded patch set 3 V -1 05/26/25, 11:39

  6. core-ci voted on patch set 3 V -1 05/26/25, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79484

  7. Benni Mack uploaded patch set 4 V -1 05/26/25, 14:23

  8. core-ci voted on patch set 4 V +1 05/26/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79497

  9. Benni Mack updated the commit message in patch set 5 V +1 05/26/25, 15:19

  10. core-ci voted on patch set 5 V +1 05/26/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79500

  11. Oli Bartsch uploaded patch set 6 V +1 05/26/25, 15:57

  12. Oli Bartsch uploaded patch set 7 05/26/25, 16:08

  13. core-ci voted on patch set 6 V -1 05/26/25, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79507

  14. Oli Bartsch commented on patch set 7 CR +1 V +1 05/26/25, 16:09

    AbstractTreeView.php:142

    Is this method used at all?
  15. core-ci voted on patch set 7 V +1 05/26/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79509

  16. Benni Mack commented on patch set 7 05/27/25, 07:46

    AbstractTreeView.php:142 Reply

    can be removed in a separate patch
  17. Andreas Kienast commented on patch set 7 CR -1 05/27/25, 09:55

    reviewing
  18. Andreas Kienast commented on patch set 7 05/27/25, 10:20

    PageInformationController.php:446

    Should we use `$languageFieldName` here as well?

    CreateRecordReactionTable.php:57

    This reads as a "workaround" to avoid another variable for the TcaSchemaFactory instance. IMO there's no reason to avoid `->has($this->table)` in favor of triggering an exception on purpose. ```suggestion $schemaFactory = GeneralUtility::makeInstance(TcaSchemaFactory::class); if ($schemaFactory->has($this->table)) { return !$schemaFactory->get($this->table)->hasCapability(TcaSchemaCapability::AccessAdminOnly); } return false; ```

    CreateRecordReactionTable.php:66

    ```suggestion $schemaFactory = GeneralUtility::makeInstance(TcaSchemaFactory::class); if (!$schemaFactory->has('sys_reaction') || !$schemaFactory->get('sys_reaction')->hasField('table_name')) { return false; } $fieldInformation = $schemaFactory->get('sys_reaction')->getField('table_name'); ```
  19. Oli Bartsch uploaded patch set 8 CR +1 V +1 05/27/25, 12:43

  20. Oli Bartsch commented on patch set 8 CR +1 V +1 05/27/25, 12:44

    PageInformationController.php:446 Reply

    Done

    CreateRecordReactionTable.php:57 Reply

    Done

    CreateRecordReactionTable.php:66 Reply

    Done
  21. core-ci voted on patch set 8 V +1 05/27/25, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79572

  22. Andreas Kienast commented on patch set 8 05/27/25, 13:19

    Reply

    Done
  23. Stefan Bürk voted on patch set 8 CR +1 V +1 06/04/25, 16:16

  24. Benni Mack voted on patch set 8 CR +2 V +2 06/04/25, 16:23

  25. Benni Mack merged patch set 9 06/04/25, 16:23