89522[TASK] Migrate various places in TYPO3 to Schema API
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 19
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+4 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabasePageLanguageOverlayRows.php+7 −3
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php2+2 −10
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php+3 −0
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+21 −13
- typo3/sysext/info/Classes/Controller/PageInformationController.php2+27 −15
- typo3/sysext/install/Classes/Service/SessionService.php+1 −1
- typo3/sysext/reactions/Classes/Form/Element/FieldMapElement.php+9 −5
- typo3/sysext/reactions/Classes/Reaction/CreateRecordReaction.php+0 −1
- typo3/sysext/reactions/Classes/Validation/CreateRecordReactionTable.php4+21 −9
- typo3/sysext/reactions/Tests/Functional/Reaction/CreateRecordReactionTest.php+1 −1
- typo3/sysext/recycler/Tests/Functional/Task/CleanerFieldProviderTest.php+0 −1
- typo3/sysext/redirects/Classes/Repository/RedirectRepository.php+10 −2
- typo3/sysext/redirects/Classes/Service/SlugService.php+11 −7
- typo3/sysext/redirects/Tests/Functional/Fixtures/Extensions/test_bolt/Classes/EventListener/AddTypoScriptFromSiteExtensionEventListener.php+27 −21
- typo3/sysext/redirects/Tests/Functional/Repository/RedirectRepositoryTest.php+7 −2
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+2 −0
- typo3/sysext/seo/Tests/Functional/MetaTag/MetaTagGeneratorTest.php+5 −1
- typo3/sysext/tstemplate/Classes/Controller/AbstractTemplateModuleController.php+19 −3
Review log 1725
-
Benni Mack uploaded patch set 1 05/26/25, 10:34
-
Benni Mack rebased onto patch set 2 05/26/25, 10:43
-
core-ci voted on patch set 1 V -1 05/26/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79479
-
core-ci voted on patch set 2 V -1 05/26/25, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79481
-
Benni Mack uploaded patch set 3
V -105/26/25, 11:39 -
core-ci voted on patch set 3 V -1 05/26/25, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79484
-
Benni Mack uploaded patch set 4
V -105/26/25, 14:23 -
core-ci voted on patch set 4 V +1 05/26/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79497
-
Benni Mack updated the commit message in patch set 5
V +105/26/25, 15:19 -
core-ci voted on patch set 5 V +1 05/26/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79500
-
Oli Bartsch uploaded patch set 6
V +105/26/25, 15:57 -
Oli Bartsch uploaded patch set 7 05/26/25, 16:08
-
core-ci voted on patch set 6 V -1 05/26/25, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79507
-
Oli Bartsch commented on patch set 7 CR +1 V +1 05/26/25, 16:09
-
core-ci voted on patch set 7 V +1 05/26/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79509
-
Benni Mack commented on patch set 7 05/27/25, 07:46
AbstractTreeView.php:142Replycan be removed in a separate patch -
Andreas Kienast commented on patch set 7 CR -1 05/27/25, 09:55
reviewing -
Andreas Kienast commented on patch set 7 05/27/25, 10:20
PageInformationController.php:446Should we use `$languageFieldName` here as well?CreateRecordReactionTable.php:57This reads as a "workaround" to avoid another variable for the TcaSchemaFactory instance. IMO there's no reason to avoid `->has($this->table)` in favor of triggering an exception on purpose. ```suggestion $schemaFactory = GeneralUtility::makeInstance(TcaSchemaFactory::class); if ($schemaFactory->has($this->table)) { return !$schemaFactory->get($this->table)->hasCapability(TcaSchemaCapability::AccessAdminOnly); } return false; ```CreateRecordReactionTable.php:66```suggestion $schemaFactory = GeneralUtility::makeInstance(TcaSchemaFactory::class); if (!$schemaFactory->has('sys_reaction') || !$schemaFactory->get('sys_reaction')->hasField('table_name')) { return false; } $fieldInformation = $schemaFactory->get('sys_reaction')->getField('table_name'); ``` -
Oli Bartsch uploaded patch set 8
CR +1V +105/27/25, 12:43 -
Oli Bartsch commented on patch set 8 CR +1 V +1 05/27/25, 12:44
PageInformationController.php:446ReplyDoneCreateRecordReactionTable.php:57ReplyDoneCreateRecordReactionTable.php:66ReplyDone -
core-ci voted on patch set 8 V +1 05/27/25, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79572
-
Andreas Kienast commented on patch set 8 05/27/25, 13:19
Reply
Done -
Stefan Bürk voted on patch set 8 CR +1 V +1 06/04/25, 16:16
-
Benni Mack voted on patch set 8 CR +2 V +2 06/04/25, 16:23
-
Benni Mack merged patch set 9 06/04/25, 16:23
AbstractTreeView.php:142