89533[BUGFIX] Properly render step-up authentication dialog in popups
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Thomas Hohn +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1621
-
Oliver Hader uploaded patch set 1 05/26/25, 17:22
-
Oliver Hader commented on patch set 1 05/26/25, 17:30
-
Benjamin Franzke voted on patch set 1 CR +1 V +1 05/26/25, 17:32
-
core-ci voted on patch set 1 V -1 05/26/25, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79511
-
Oliver Hader commented on patch set 1 05/26/25, 17:45
sudo-mode.ts:215ReplyI'll keep it like that... -
core-ci commented on patch set 1 05/26/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79511
-
Oliver Hader uploaded patch set 2
CR +1V +105/26/25, 18:01 -
core-ci voted on patch set 2 V -1 05/26/25, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79512
-
Oliver Hader uploaded patch set 3
V -105/26/25, 18:08 -
Oliver Hader commented on patch set 3 05/26/25, 18:09
sudo-mode.ts:215ReplyI forgot, the modal is applied to the top frame... thus, it is required. -
core-ci voted on patch set 3 V +1 05/26/25, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79513
-
Thomas Hohn voted on patch set 3 CR +1 05/26/25, 19:28
-
Oliver Hader updated the commit message in patch set 4
CR +1V +105/26/25, 20:00 -
core-ci voted on patch set 4 V +1 05/26/25, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79517
-
Thomas Hohn voted on patch set 4 CR +1 05/27/25, 05:07
-
Benjamin Franzke commented on patch set 4 CR +1 V +1 05/27/25, 05:11
sudo-mode.ts:215Replyack, `window !== top` would also be good, but `self` (which is just a proxy) is fine for me as well. -
Benjamin Franzke marked it work in progress 05/27/25, 06:10
-
Benjamin Franzke marked it ready for review 05/27/25, 06:37
-
Oli Bartsch voted on patch set 4 CR +1 V +1 05/27/25, 09:48
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 05/27/25, 09:51
-
Benjamin Franzke merged patch set 5 05/27/25, 09:52
sudo-mode.ts:215