Review main Merged

89533[BUGFIX] Properly render step-up authentication dialog in popups

Oliver Hader CR +2 V +2 Easy +16 −4 updated 05/27/25, 09:52

Commit message

The step-up authentication dialog is assumed to be rendered in
a nested sub-frame - instead of appearing standalone in the top
frame. In this scenario, the global setting `TYPO3.configuration`
is not given and the JavaScript module router instance is not
available.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Thomas Hohn +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1621

  1. Oliver Hader uploaded patch set 1 05/26/25, 17:22

  2. Oliver Hader commented on patch set 1 05/26/25, 17:30

    sudo-mode.ts:215

    It also would be possible, to but the top-frame handling to handling the rejected promise...
  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 05/26/25, 17:32

  4. core-ci voted on patch set 1 V -1 05/26/25, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79511

  5. Oliver Hader commented on patch set 1 05/26/25, 17:45

    sudo-mode.ts:215 Reply

    I'll keep it like that...
  6. core-ci commented on patch set 1 05/26/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79511

  7. Oliver Hader uploaded patch set 2 CR +1 V +1 05/26/25, 18:01

  8. core-ci voted on patch set 2 V -1 05/26/25, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79512

  9. Oliver Hader uploaded patch set 3 V -1 05/26/25, 18:08

  10. Oliver Hader commented on patch set 3 05/26/25, 18:09

    sudo-mode.ts:215 Reply

    I forgot, the modal is applied to the top frame... thus, it is required.
  11. core-ci voted on patch set 3 V +1 05/26/25, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79513

  12. Thomas Hohn voted on patch set 3 CR +1 05/26/25, 19:28

  13. Oliver Hader updated the commit message in patch set 4 CR +1 V +1 05/26/25, 20:00

  14. core-ci voted on patch set 4 V +1 05/26/25, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79517

  15. Thomas Hohn voted on patch set 4 CR +1 05/27/25, 05:07

  16. Benjamin Franzke commented on patch set 4 CR +1 V +1 05/27/25, 05:11

    sudo-mode.ts:215 Reply

    ack, `window !== top` would also be good, but `self` (which is just a proxy) is fine for me as well.
  17. Benjamin Franzke marked it work in progress 05/27/25, 06:10

  18. Benjamin Franzke marked it ready for review 05/27/25, 06:37

  19. Oli Bartsch voted on patch set 4 CR +1 V +1 05/27/25, 09:48

  20. Benjamin Franzke voted on patch set 4 CR +2 V +2 05/27/25, 09:51

  21. Benjamin Franzke merged patch set 5 05/27/25, 09:52