Review main Merged

89536[BUGFIX] Use correct language capability field in route mapper

Oli Bartsch CR +2 V +2 Easy +9 −12 updated 05/30/25, 08:47

Commit message

Additionally, adjust a couple of source
field usages to properly use the has*()
method and make use of null-safe-operator.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 57

  1. Oli Bartsch uploaded patch set 1 05/26/25, 20:19

  2. Oli Bartsch updated the commit message in patch set 2 05/26/25, 20:20

  3. core-ci voted on patch set 1 V +1 05/26/25, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79518

  4. core-ci voted on patch set 2 V +1 05/26/25, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79519

  5. Benni Mack voted on patch set 2 CR +1 V +1 05/27/25, 05:28

  6. Benjamin Franzke commented on patch set 2 CR +2 V +2 05/30/25, 08:46

    I don't like that this patch mixes BUGFIX (https://forge.typo3.org/issues/106798 – in the route aspect mappers) and refactorings in one patch, but it works, so I'll not object…
  7. Benjamin Franzke merged patch set 3 05/30/25, 08:47