Review 12.4 Merged

89557[BUGFIX] Properly render step-up authentication dialog in popups

Benjamin Franzke CR +2 V +2 Easy +16 −4 updated 05/27/25, 09:52

Commit message

The step-up authentication dialog is assumed to be rendered in
a nested sub-frame - instead of appearing standalone in the top
frame. In this scenario, the global setting `TYPO3.configuration`
is not given and the JavaScript module router instance is not
available.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 05/27/25, 06:16

  2. core-ci voted on patch set 1 V +1 05/27/25, 06:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79541

  3. Benjamin Franzke commented on patch set 1 05/27/25, 09:52

    This change is ready for review.
  4. Benjamin Franzke merged patch set 2 05/27/25, 09:52