Review main Merged

89559[BUGFIX] Add mime-type compatiblity mapping for .exe

Benjamin Franzke CR +2 V +2 Easy +3 −0 updated 05/27/25, 12:06

Commit message

PHP `finfo_file()` and `mime_content_type()` often report
exe files as `application/x-dosexec` instead of
`application/x-msdos-program`. Ensure that the MIME type
is normalized to the latter ones, and thus exe files can
be uploaded, if allowed in miscfile_ext.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Benjamin Franzke uploaded patch set 1 05/27/25, 10:48

  2. core-ci voted on patch set 1 V +1 05/27/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79553

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 05/27/25, 10:56

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 05/27/25, 11:43

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 05/27/25, 11:45

  6. Benjamin Franzke merged patch set 2 05/27/25, 11:45

  7. Oliver Hader voted on patch set 2 CR +1 05/27/25, 12:06