Review main Merged

89562[TASK] Remove unused `additionalCssClasses` from dashboard widgets

Benjamin Kott CR +2 V +2 Easy +1 −46 updated 05/28/25, 09:41

Commit message

Additional classes is not used in rendering the dashboard widgets.
Even it was part of the interface it was never evaluated and passed
to the rendering, it was never called but documented. To avoid
confusions we are dropping it here retroactive as it has no effect.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Benjamin Kott uploaded patch set 1 05/27/25, 11:56

  2. core-ci voted on patch set 1 V +1 05/27/25, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79563

  3. Benjamin Franzke rebased onto patch set 2 V +1 05/28/25, 08:00

  4. core-ci voted on patch set 2 V +1 05/28/25, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79608

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 05/28/25, 09:10

  6. Benni Mack voted on patch set 2 CR +1 V +1 05/28/25, 09:40

  7. Benjamin Franzke voted on patch set 2 CR +2 V +2 05/28/25, 09:41

  8. Benjamin Franzke merged patch set 3 05/28/25, 09:41