Review main Merged

89593[BUGFIX] Keep `foreign_match_fields` in TcaMigration

Oli Bartsch CR +2 V +2 Easy +44 −4 updated 05/31/25, 09:33

Commit message

Since there may be valid use cases for using
`foreign_match_fields` in file configurations
— particularly in FlexForm contexts — this
setting is no longer removed during migration
and will be applied during TcaPreparation
if present.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • Cyril Janody +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • Cyril Janody +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 89

  1. Oli Bartsch uploaded patch set 1 05/30/25, 07:55

  2. core-ci voted on patch set 1 V +1 05/30/25, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79688

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 05/30/25, 08:03

  4. Nikita Hovratov voted on patch set 1 CR +1 V +1 05/30/25, 08:07

  5. Cyril Janody voted on patch set 1 CR +1 05/30/25, 15:43

  6. Cyril Janody voted on patch set 1 V +1 05/30/25, 16:21

  7. Cyril Janody commented on patch set 1 05/30/25, 16:31

    Should we add a TCA example in ext:styleguide? It can be based on the one provide by Georg Ringer.
  8. Oli Bartsch commented on patch set 1 CR +2 V +2 05/31/25, 08:43

    Reply

    Sure we could add an example using this option in a flexform, but this would requires a corresponding foreign side too. So yes, but let's do this is a separat patch.
  9. Oli Bartsch merged patch set 2 05/31/25, 09:33