89594[BUGFIX] Prevent exceptions on new FormEngine scheduler task changes
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 2
Review log 1217
-
Garvin Hicking uploaded patch set 1 05/30/25, 12:36
-
core-ci voted on patch set 1 V -1 05/30/25, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79697
-
Benni Mack uploaded patch set 2
V -106/02/25, 12:32 -
core-ci voted on patch set 2 V +1 06/02/25, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79749
-
Benni Mack uploaded patch set 3
V +106/02/25, 12:50 -
core-ci voted on patch set 3 V +1 06/02/25, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79752
-
Benni Mack uploaded patch set 4
V +106/02/25, 13:04 -
Benni Mack voted on patch set 4 CR +1 V +1 06/02/25, 13:06
-
core-ci voted on patch set 4 V +1 06/02/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79754
-
Benjamin Franzke commented on patch set 4 CR -1 06/03/25, 06:05
-
Benni Mack commented on patch set 4 06/03/25, 11:41
TaskService.php:250ReplyThis is a side-effect of the current process of using DataHandler + FormEngine, as this is a custom renderType of FormEngine, because AdditionalFieldProviders deliver HTML Code directly, and distinguish between ADD and EDIT. FormEngine actually allows to change task types - this wasn't possible in the past. We could fix this in all additional field providers from Core, but then ext authors would need to fix this as well - I would say, that this would be breaking. Instead, I would like to introduce a new way to use "real" FormEngine / TCA fields and migrate away from additional field providers. There is one example here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89605 -
Benjamin Franzke commented on patch set 4 06/03/25, 12:28
TaskService.php:250Reply UnresolvedYes, but if we are not breaking here, we need to silence warnings as long as we are support the additional field providers. So, maybe we should only catch `\Error` (if at all, I still do not like it…) or change to ``` @$provider?->saveAdditionalFields($incomingData, $task); ``` which should be better and more explicit than the catch-all-and-everything approach. -
Benni Mack uploaded patch set 5
CR +1V +106/03/25, 13:25 -
core-ci voted on patch set 5 V +1 06/03/25, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79799
-
Garvin Hicking commented on patch set 5 06/03/25, 13:59
This works partially for me. As discussed with Benni yesterday, the following case is not yet covered (not sure whether we could address this in a follow-up, or here) Case in which "PHP Warning: Undefined array key "TYPO3\CMS\Scheduler\Task\OptimizeDatabaseTableTask" in /var/www/html/typo3-core/typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php line 171" occurs: * Create scheduler task * Switch to "Optimize Table" * Select tables * Save * Switch back to a task without "tables", for example "UpdateExtensionList" This throws an error because the new task has no fields like "tables" but tries to access validation for the "previous" tasktype. -
Benni Mack commented on patch set 5 09/25/25, 13:49
I think we can abandon this one. We removed the possibility to change task types -
Garvin Hicking abandoned the change 09/25/25, 14:14
Yes! :-)
TaskService.php:250