89596[BUGFIX] Properly handle hide / unhide inline controls
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 2
Files 12
- Build/Sources/Sass/typo3/_element_tceforms.scss+16 −3
- Build/Sources/TypeScript/backend/form-engine/container/files-control-container.ts+44 −28
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+44 −27
- Build/Sources/TypeScript/backend/form-engine.ts+1 −1
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php+3 −3
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+9 −8
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/files-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FileCest.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_1n_inline_2_child.php+33 −1
Review log 2028
Show 23 earlier messages
-
Oli Bartsch uploaded patch set 1 05/30/25, 14:03
-
core-ci voted on patch set 1 V +1 05/30/25, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79699
-
Oli Bartsch uploaded patch set 2
V +106/06/25, 14:22
-
core-ci voted on patch set 2 V -1 06/06/25, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79996
-
Oli Bartsch uploaded patch set 3
V -106/06/25, 16:54 -
core-ci voted on patch set 3 V +1 06/06/25, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80003
-
Oli Bartsch commented on patch set 3 06/06/25, 19:35
tx_styleguide_inline_1n is good for testing. -
Oli Bartsch uploaded patch set 4
V +106/06/25, 19:42 -
core-ci voted on patch set 4 V -1 06/06/25, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80010
-
Nikita Hovratov voted on patch set 4 V +1 06/06/25, 19:55
-
Oli Bartsch uploaded patch set 5
V +106/06/25, 19:59 -
core-ci voted on patch set 5 V +1 06/06/25, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80011
-
Nikita Hovratov voted on patch set 5 V +1 06/06/25, 20:22
-
Georg Ringer voted on patch set 5 CR +1 V +1 06/07/25, 05:50
-
Oli Bartsch commented on patch set 5 V -1 06/07/25, 07:35
Unresolved
Still does not work reliable .. -
Oli Bartsch uploaded patch set 6
CR +1V +106/23/25, 20:06 -
Oli Bartsch uploaded patch set 7 06/23/25, 20:12
-
core-ci voted on patch set 6 V -1 06/23/25, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80656
-
core-ci voted on patch set 7 V -1 06/23/25, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80657
-
Oli Bartsch commented on patch set 7 V -1 06/24/25, 06:31
No No No.. this does still not work.. -
Benni Mack commented on patch set 7 07/03/25, 07:59
Reply
my client is actively running in this problem after our upgrade to v13. Should we continue this way, or go with https://review.typo3.org/c/Packages/TYPO3.CMS/+/88305? -
Oli Bartsch commented on patch set 7 07/03/25, 11:44
Reply Unresolved
I think we should go this way, as it also solves the backend part of properly rendering hidden inputs. However, I haven’t yet managed to get the JavaScript part working reliably, especially in constellations like inline within inline with files, etc. -
Peter Kraume commented on patch set 7 12/19/25, 16:43
Are there any plans to continue on this patch? -
Oli Bartsch commented on patch set 7 01/09/26, 11:24
Reply
I would like to, but as far as I remember this turned into quite a rabbit hole. We would probably need to start from scratch. At the moment my focus is on v14 topics, so I do not see myself taking this on in the near future. That said, everyone is very welcome to pick this up. -
Benni Mack wrote 04/21/26, 14:53
Removed cc Benni Mack. -
Benni Mack updated the commit message in patch set 8
V -104/22/26, 06:27 -
core-ci voted on patch set 8 V -1 04/22/26, 06:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100703
-
Georg Ringer abandoned the change 09/09/26, 15:03