Review main Abandoned

89596[BUGFIX] Properly handle hide / unhide inline controls

Oli Bartsch CR 0 V -1 Normal +155 −76 updated 09/09/26, 15:03

Commit message

Hiding and unhiding inline records and file
references has long been unreliable due to
various edge cases. These scenarios are
now properly handled.

The hide/unhide control buttons are now
always in sync with their corresponding
form field values — regardless of whether
the field is visible or rendered as a
hidden field.

This also applies to newly created records:
the disabled field is now added as a hidden
input when needed to ensure correct behavior.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 2

Files 12

Review log 2028

Show 23 earlier messages
  1. Oli Bartsch uploaded patch set 1 05/30/25, 14:03

  2. core-ci voted on patch set 1 V +1 05/30/25, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79699

  3. Oli Bartsch uploaded patch set 2 V +1 06/06/25, 14:22

  1. core-ci voted on patch set 2 V -1 06/06/25, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79996

  2. Oli Bartsch uploaded patch set 3 V -1 06/06/25, 16:54

  3. core-ci voted on patch set 3 V +1 06/06/25, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80003

  4. Oli Bartsch commented on patch set 3 06/06/25, 19:35

    tx_styleguide_inline_1n is good for testing.
  5. Oli Bartsch uploaded patch set 4 V +1 06/06/25, 19:42

  6. core-ci voted on patch set 4 V -1 06/06/25, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80010

  7. Nikita Hovratov voted on patch set 4 V +1 06/06/25, 19:55

  8. Oli Bartsch uploaded patch set 5 V +1 06/06/25, 19:59

  9. core-ci voted on patch set 5 V +1 06/06/25, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80011

  10. Nikita Hovratov voted on patch set 5 V +1 06/06/25, 20:22

  11. Georg Ringer voted on patch set 5 CR +1 V +1 06/07/25, 05:50

  12. Oli Bartsch commented on patch set 5 V -1 06/07/25, 07:35

    Unresolved

    Still does not work reliable ..
  13. Oli Bartsch uploaded patch set 6 CR +1 V +1 06/23/25, 20:06

  14. Oli Bartsch uploaded patch set 7 06/23/25, 20:12

  15. core-ci voted on patch set 6 V -1 06/23/25, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80656

  16. core-ci voted on patch set 7 V -1 06/23/25, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80657

  17. Oli Bartsch commented on patch set 7 V -1 06/24/25, 06:31

    No No No.. this does still not work..
  18. Benni Mack commented on patch set 7 07/03/25, 07:59

    Reply

    my client is actively running in this problem after our upgrade to v13. Should we continue this way, or go with https://review.typo3.org/c/Packages/TYPO3.CMS/+/88305?
  19. Oli Bartsch commented on patch set 7 07/03/25, 11:44

    Reply Unresolved

    I think we should go this way, as it also solves the backend part of properly rendering hidden inputs. However, I haven’t yet managed to get the JavaScript part working reliably, especially in constellations like inline within inline with files, etc.
  20. Peter Kraume commented on patch set 7 12/19/25, 16:43

    Are there any plans to continue on this patch?
  21. Oli Bartsch commented on patch set 7 01/09/26, 11:24

    Reply

    I would like to, but as far as I remember this turned into quite a rabbit hole. We would probably need to start from scratch. At the moment my focus is on v14 topics, so I do not see myself taking this on in the near future. That said, everyone is very welcome to pick this up.
  22. Benni Mack wrote 04/21/26, 14:53

    Removed cc Benni Mack.
  23. Benni Mack updated the commit message in patch set 8 V -1 04/22/26, 06:27

  24. core-ci voted on patch set 8 V -1 04/22/26, 06:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100703

  25. Georg Ringer abandoned the change 09/09/26, 15:03