Review main Merged

89597[BUGFIX] Fix indefinite sudo confirmation when copying backend users

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 06/03/25, 14:08

Commit message

With #106743 the DataHandler sudo mode access subjects (that were added
in #103252) have been extended with the record identifier as subject
context.
For new or copied record there is no UID yet, therefore a randomized
string is used, which causes issues with password grants which act
as one-time grants and therefore need an exact subject match, where
a randomized identifier causes the access subject to never match.

To solve this, the randomized NEW.+ identifiers are normalized to NEW,
in order to create stable sudo mode authentication claims, that do not
change between claim creation and claim consumption.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 911

  1. Benjamin Franzke uploaded patch set 1 05/30/25, 14:04

  2. core-ci voted on patch set 1 V +1 05/30/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79700

  3. Oliver Hader voted on patch set 1 CR +1 06/02/25, 11:36

  4. Oliver Hader commented on patch set 1 V +1 06/02/25, 11:57

    DataHandlerAuthenticationContext.php:73

    I guess just checking for `NEW` in the beginning would be fine as well, e.g. ``` str_starts_with((string)$id, 'NEW') ? 'NEW' : (string)$id, ```
  5. Benjamin Franzke uploaded patch set 2 CR +1 V +1 06/02/25, 12:11

  6. Benjamin Franzke commented on patch set 2 06/02/25, 12:11

    DataHandlerAuthenticationContext.php:73 Reply

    ack 🤦 much better, done!
  7. core-ci voted on patch set 2 V +1 06/02/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79748

  8. Oliver Hader voted on patch set 2 CR +1 V +1 06/02/25, 12:18

  9. Nikita Hovratov voted on patch set 2 CR +1 V +1 06/03/25, 13:18

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/03/25, 13:55

  11. Benjamin Franzke merged patch set 3 06/03/25, 14:08