Review main Merged

89601[TASK] Use symfony rate limiter for backend password recovery

Torben Hansen CR +2 V +2 Normal +88 −28 updated 06/02/25, 10:22

Commit message

The backend password reset functionality currently relies
on a hardcoded rate limit of 3 attempts within 30 minutes,
evaluated via sys_log entries.

This change replaces the custom logic with the Symfony
RateLimiter component, aligning it with the approach used
in ext:felogin.

The default configuration of 3 attempts within 30 minutes
is preserved and can now be adjusted via dependency
injection.

A new functional test ensures that the rate limiter is
correctly applied during backend password recovery.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Torben Hansen uploaded patch set 1 06/02/25, 06:02

  2. core-ci voted on patch set 1 V +1 06/02/25, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79738

  3. Oliver Hader uploaded patch set 2 V +1 06/02/25, 08:55

  4. Oliver Hader commented on patch set 2 CR +1 V +1 06/02/25, 08:57

    Good catch & it's great to see the `sys_log` magic disappearing... 😊
  5. core-ci voted on patch set 2 V +1 06/02/25, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79741

  6. Benni Mack commented on patch set 2 CR +1 V +1 06/02/25, 09:29

    thank you!
  7. Oliver Hader commented on patch set 2 06/02/25, 09:33

    I'll take care of back-ports and merges...
  8. Oliver Hader voted on patch set 2 CR +2 V +2 06/02/25, 10:21

  9. Oliver Hader merged patch set 3 06/02/25, 10:22