Review main Merged

89605[FEATURE] Use custom TCA types over AdditionalFieldProviders

Benni Mack CR +2 V +2 Nightmare +1264 −1451 updated 09/25/25, 13:42

Commit message

This change allows to register TCA types for scheduler tasks.

This way, custom fields with custom validation can be developed
just like developers are used from regular TCA features.

We can now get rid of three major differences of
tx_scheduler_task records over the current approach.

1. We use native DB fields with auto-creating fields via TCA

2. Custom registration of tasks can be removed, as they are
   handled via the tasktype items.

3. Custom AdditionalFieldProviders are now a thing of the past
   as this is now handled via TCA fields.

Also, since validation etc. is handled by FormEngine,
this approach is MUCH safer for extension authors to avoid
XSS or SQLi in their own code.

Tasks registered via custom TCA types will now not
call $task->getTaskParameters() for storing
information in the DB field as JSON-serialized anymore (only
when doing the migration), but will receive the full record
array in $task->setTaskParameters(array $parameters).

The class name of the task now matches the
value of the field "tasktype" inside the database.

The existing task migration is adapted to also migrate
additional fields (and thus, unset "parameters" after migration).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 52

Show 32 more files

Review log 5294

Show 3569 earlier messages
  1. Benni Mack uploaded patch set 1 06/02/25, 15:56

  2. core-ci voted on patch set 1 V -1 06/02/25, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79762

  3. Benni Mack uploaded patch set 2 V -1 06/02/25, 16:22

  4. Benni Mack updated the commit message in patch set 3 06/02/25, 16:28

  5. core-ci voted on patch set 2 V -1 06/02/25, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79765

  6. core-ci voted on patch set 3 V -1 06/02/25, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79766

  7. Benni Mack updated the commit message in patch set 4 V -1 06/02/25, 16:49

  8. core-ci voted on patch set 4 V -1 06/02/25, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79767

  9. Benni Mack uploaded patch set 5 V -1 09/12/25, 22:18

  10. core-ci voted on patch set 5 V -1 09/12/25, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84933

  11. Benni Mack uploaded patch set 6 V -1 09/14/25, 11:52

  12. core-ci voted on patch set 6 V -1 09/14/25, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84958

  13. Benni Mack uploaded patch set 7 V -1 09/15/25, 13:42

  14. core-ci voted on patch set 7 V -1 09/15/25, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84989

  15. Benni Mack uploaded patch set 8 V -1 09/16/25, 12:40

  16. core-ci voted on patch set 8 V -1 09/16/25, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85030

  17. Benni Mack uploaded patch set 9 V -1 09/16/25, 14:05

  18. core-ci voted on patch set 9 V -1 09/16/25, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85035

  19. Benni Mack uploaded patch set 10 V -1 09/16/25, 14:34

  20. core-ci voted on patch set 10 V -1 09/16/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85036

  21. Benni Mack uploaded patch set 11 V -1 09/16/25, 15:15

  22. core-ci voted on patch set 11 V +1 09/16/25, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85037

  23. Benni Mack uploaded patch set 12 V +1 09/16/25, 15:46

  24. core-ci voted on patch set 12 V -1 09/16/25, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85038

  25. Benni Mack uploaded patch set 13 V -1 09/16/25, 21:14

  26. Benni Mack uploaded patch set 14 09/16/25, 21:15

  27. core-ci voted on patch set 13 V -1 09/16/25, 21:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85043

  28. core-ci voted on patch set 14 V -1 09/16/25, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85044

  29. Benni Mack uploaded patch set 15 V -1 09/16/25, 21:30

  30. core-ci voted on patch set 15 V +1 09/16/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85045

  31. Benni Mack uploaded patch set 16 V +1 09/17/25, 05:21

  32. Benni Mack uploaded patch set 17 09/17/25, 05:24

  33. core-ci voted on patch set 16 V -1 09/17/25, 05:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85057

  34. core-ci voted on patch set 17 V -1 09/17/25, 05:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85058

  35. Benni Mack uploaded patch set 18 V -1 09/17/25, 05:42

  36. core-ci voted on patch set 18 V +1 09/17/25, 05:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85059

  37. Oli Bartsch uploaded patch set 19 V +1 09/18/25, 15:30

  38. core-ci voted on patch set 19 V -1 09/18/25, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85124

  39. Oli Bartsch uploaded patch set 20 V -1 09/18/25, 20:53

  40. core-ci voted on patch set 20 V -1 09/18/25, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85133

  41. Oli Bartsch uploaded patch set 21 V -1 09/18/25, 21:31

  42. core-ci voted on patch set 21 V +1 09/18/25, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85135

  43. Oli Bartsch uploaded patch set 22 V +1 09/23/25, 08:12

  44. core-ci voted on patch set 22 V +1 09/23/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85370

  45. Benni Mack uploaded patch set 23 V +1 09/23/25, 13:04

  46. core-ci voted on patch set 23 V -1 09/23/25, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85384

  47. Benni Mack uploaded patch set 24 V -1 09/23/25, 13:30

  48. core-ci voted on patch set 24 V -1 09/23/25, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85386

  49. Benni Mack uploaded patch set 25 V -1 09/23/25, 13:50

  50. Benni Mack uploaded patch set 26 09/23/25, 13:57

  51. core-ci voted on patch set 25 V -1 09/23/25, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85387

  52. core-ci voted on patch set 26 V -1 09/23/25, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85389

  53. Benni Mack uploaded patch set 27 V -1 09/23/25, 14:11

  54. Benni Mack uploaded patch set 28 09/23/25, 14:19

  55. core-ci voted on patch set 27 V -1 09/23/25, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85390

  56. core-ci voted on patch set 28 V +1 09/23/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85391

  57. Benni Mack uploaded patch set 29 V +1 09/23/25, 14:39

  58. core-ci voted on patch set 29 V -1 09/23/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85392

  59. Benni Mack uploaded patch set 30 V -1 09/23/25, 15:01

  60. core-ci voted on patch set 30 V -1 09/23/25, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85393

  61. Benni Mack uploaded patch set 31 V -1 09/23/25, 15:17

  62. Benni Mack uploaded patch set 32 09/23/25, 15:26

  63. core-ci voted on patch set 31 V -1 09/23/25, 15:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85395

  64. core-ci voted on patch set 32 V -1 09/23/25, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85396

  65. Benni Mack uploaded patch set 33 V -1 09/24/25, 06:23

  66. core-ci voted on patch set 33 V +1 09/24/25, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85423

  67. Benni Mack uploaded patch set 34 V +1 09/24/25, 12:21

  68. core-ci voted on patch set 34 V +1 09/24/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85447

  69. Simon Schaufelberger commented on patch set 34 09/24/25, 14:08

    TaskService.php:363

    how can this ever be null?

    file_storage_indexing_task.php:14

    indentation can be reduced one level

    optimize_database_table_task.php:14

    indentation can be reduced one level

    recycler_garbage_collection_task.php:14

    indentation can be reduced one level
  1. Benni Mack uploaded patch set 35 V +1 09/24/25, 14:24

  2. Benni Mack commented on patch set 35 09/24/25, 14:24

    TaskService.php:363 Reply

    yes. in Install Tool.

    file_storage_indexing_task.php:14 Reply

    Done

    optimize_database_table_task.php:14 Reply

    Done

    recycler_garbage_collection_task.php:14 Reply

    Done
  3. core-ci voted on patch set 35 V +1 09/24/25, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85452

  4. Benni Mack uploaded patch set 36 V +1 09/24/25, 15:26

  5. core-ci voted on patch set 36 V +1 09/24/25, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85457

  6. Oli Bartsch uploaded patch set 37 V +1 09/24/25, 20:30

  7. core-ci voted on patch set 37 V -1 09/24/25, 20:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85466

  8. Oli Bartsch uploaded patch set 38 V -1 09/25/25, 08:33

  9. core-ci voted on patch set 38 V -1 09/25/25, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85492

  10. Oli Bartsch uploaded patch set 39 V -1 09/25/25, 09:29

  11. core-ci voted on patch set 39 V -1 09/25/25, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85495

  12. Oli Bartsch uploaded patch set 40 V -1 09/25/25, 09:46

  13. core-ci voted on patch set 40 V -1 09/25/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85497

  14. Oli Bartsch uploaded patch set 41 V -1 09/25/25, 11:12

  15. core-ci voted on patch set 41 V +1 09/25/25, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85503

  16. Oli Bartsch voted on patch set 41 CR +1 V +1 09/25/25, 11:25

  17. Simon Schaufelberger commented on patch set 41 09/25/25, 12:01

    scheduler_download_extensionlist_task.php:6

    I prefer having these classes being imported. Do you agree?

    scheduler_cleaner_task.php:6

    I prefer having these classes being imported. Do you agree?

    scheduler_caching_framework_garbage_collection_task.php:5

    I prefer having these classes being imported. Do you agree?
  18. Oli Bartsch commented on patch set 41 09/25/25, 12:03

    scheduler_download_extensionlist_task.php:6 Reply

    Feel free to adjust I don't care.

    scheduler_cleaner_task.php:6 Reply

    Done

    scheduler_caching_framework_garbage_collection_task.php:5 Reply

    Done
  19. Simon Schaufelberger uploaded patch set 42 CR +1 V +1 09/25/25, 12:45

  20. Georg Ringer voted on patch set 42 CR +1 V +1 09/25/25, 12:52

  21. Simon Schaufelberger voted on patch set 42 CR +1 09/25/25, 12:53

  22. core-ci voted on patch set 42 V +1 09/25/25, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85518

  23. Garvin Hicking commented on patch set 42 CR +1 V +1 09/25/25, 13:37

    YES! Kudos, I followed this for long and really admire the effort put into this. Thanks!
  24. Oli Bartsch voted on patch set 42 CR +2 V +2 09/25/25, 13:42

  25. Oli Bartsch merged patch set 43 09/25/25, 13:42