89605[FEATURE] Use custom TCA types over AdditionalFieldProviders
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 52
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/core/Classes/Schema/Field/FieldCollection.php+5 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107526-CustomTCATypesForSchedulerTasks.rstnew+315 −0
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/SchedulerTaskWizardCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.php+6 −2
- typo3/sysext/extensionmanager/Configuration/TCA/Overrides/scheduler_download_extensionlist_task.php2new+37 −0
- typo3/sysext/extensionmanager/ext_localconf.phpdeleted+0 −21
- typo3/sysext/recycler/Classes/Task/CleanerFieldProvider.phpdeleted+0 −225
- typo3/sysext/recycler/Classes/Task/CleanerTask.php+33 −30
- typo3/sysext/recycler/Configuration/TCA/Overrides/scheduler_cleaner_task.php2new+47 −0
- typo3/sysext/recycler/Tests/Functional/Task/CleanerFieldProviderTest.phpdeleted+0 −108
- typo3/sysext/recycler/Tests/Functional/Task/CleanerTaskTest.php+3 −4
- typo3/sysext/recycler/ext_localconf.phpdeleted+0 −15
- typo3/sysext/scheduler/Classes/Command/SchedulerCommand.php+5 −2
- typo3/sysext/scheduler/Classes/Command/SchedulerExecuteCommand.php+4 −1
- typo3/sysext/scheduler/Classes/Controller/NewSchedulerTaskController.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+0 −2
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php+2 −4
- typo3/sysext/scheduler/Classes/Form/Element/AdditionalSchedulerFieldsElement.php+7 −11
- typo3/sysext/scheduler/Classes/Form/Element/RegisteredExtractors.phpnew+85 −0
Show 32 more files
- typo3/sysext/scheduler/Classes/Form/Element/TaskTypeInfoElement.phpnew+70 −0
- typo3/sysext/scheduler/Classes/Hooks/SchedulerTaskPersistenceValidator.php+2 −2
- typo3/sysext/scheduler/Classes/Migration/SchedulerDatabaseStorageMigration.php+64 −28
- typo3/sysext/scheduler/Classes/Service/TaskService.php2+94 −37
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+10 −1
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionAdditionalFieldProvider.phpdeleted+0 −155
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionTask.php+23 −2
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.phpdeleted+0 −216
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionTask.php+6 −10
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.phpdeleted+0 −128
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingTask.php+2 −2
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.phpdeleted+0 −240
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableTask.php+100 −2
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionAdditionalFieldProvider.phpdeleted+0 −112
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionTask.php+4 −2
- typo3/sysext/scheduler/Classes/Task/TaskSerializer.php+23 −11
- typo3/sysext/scheduler/Configuration/TCA/Overrides/scheduler_caching_framework_garbage_collection_task.php2new+50 −0
- typo3/sysext/scheduler/Configuration/TCA/Overrides/scheduler_file_storage_extraction_task.phpnew+58 −0
- typo3/sysext/scheduler/Configuration/TCA/Overrides/scheduler_file_storage_indexing_task.phpnew+32 −0
- typo3/sysext/scheduler/Configuration/TCA/Overrides/scheduler_optimize_database_table_task.phpnew+46 −0
- typo3/sysext/scheduler/Configuration/TCA/Overrides/scheduler_recycler_garbage_collection_task.phpnew+45 −0
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task.php+35 −3
- typo3/sysext/scheduler/Configuration/user.tsconfignew+1 −0
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/scheduler/Resources/Private/Language/locallang_tca.xlf+9 −0
- typo3/sysext/scheduler/Resources/Private/Partials/GroupUnusedList.html+2 −5
- typo3/sysext/scheduler/Tests/Functional/Controller/NewSchedulerTaskControllerTest.php+2 −2
- typo3/sysext/scheduler/Tests/Functional/Fixtures/DatabaseStorageMigrationApplied.csvbinary
- typo3/sysext/scheduler/Tests/Functional/Fixtures/DatabaseStorageMigrationBase.csvbinary
- typo3/sysext/scheduler/Tests/Functional/Migration/SchedulerDatabaseStorageMigrationTest.php+5 −1
- typo3/sysext/scheduler/Tests/Unit/Task/TaskSerializerTest.php+3 −1
- typo3/sysext/scheduler/ext_localconf.php+20 −54
Review log 5294
Show 3569 earlier messages
-
Benni Mack uploaded patch set 1 06/02/25, 15:56
-
core-ci voted on patch set 1 V -1 06/02/25, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79762
-
Benni Mack uploaded patch set 2
V -106/02/25, 16:22 -
Benni Mack updated the commit message in patch set 3 06/02/25, 16:28
-
core-ci voted on patch set 2 V -1 06/02/25, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79765
-
core-ci voted on patch set 3 V -1 06/02/25, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79766
-
Benni Mack updated the commit message in patch set 4
V -106/02/25, 16:49 -
core-ci voted on patch set 4 V -1 06/02/25, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79767
-
Benni Mack uploaded patch set 5
V -109/12/25, 22:18 -
core-ci voted on patch set 5 V -1 09/12/25, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84933
-
Benni Mack uploaded patch set 6
V -109/14/25, 11:52 -
core-ci voted on patch set 6 V -1 09/14/25, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84958
-
Benni Mack uploaded patch set 7
V -109/15/25, 13:42 -
core-ci voted on patch set 7 V -1 09/15/25, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84989
-
Benni Mack uploaded patch set 8
V -109/16/25, 12:40 -
core-ci voted on patch set 8 V -1 09/16/25, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85030
-
Benni Mack uploaded patch set 9
V -109/16/25, 14:05 -
core-ci voted on patch set 9 V -1 09/16/25, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85035
-
Benni Mack uploaded patch set 10
V -109/16/25, 14:34 -
core-ci voted on patch set 10 V -1 09/16/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85036
-
Benni Mack uploaded patch set 11
V -109/16/25, 15:15 -
core-ci voted on patch set 11 V +1 09/16/25, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85037
-
Benni Mack uploaded patch set 12
V +109/16/25, 15:46 -
core-ci voted on patch set 12 V -1 09/16/25, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85038
-
Benni Mack uploaded patch set 13
V -109/16/25, 21:14 -
Benni Mack uploaded patch set 14 09/16/25, 21:15
-
core-ci voted on patch set 13 V -1 09/16/25, 21:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85043
-
core-ci voted on patch set 14 V -1 09/16/25, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85044
-
Benni Mack uploaded patch set 15
V -109/16/25, 21:30 -
core-ci voted on patch set 15 V +1 09/16/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85045
-
Benni Mack uploaded patch set 16
V +109/17/25, 05:21 -
Benni Mack uploaded patch set 17 09/17/25, 05:24
-
core-ci voted on patch set 16 V -1 09/17/25, 05:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85057
-
core-ci voted on patch set 17 V -1 09/17/25, 05:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85058
-
Benni Mack uploaded patch set 18
V -109/17/25, 05:42 -
core-ci voted on patch set 18 V +1 09/17/25, 05:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85059
-
Oli Bartsch uploaded patch set 19
V +109/18/25, 15:30 -
core-ci voted on patch set 19 V -1 09/18/25, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85124
-
Oli Bartsch uploaded patch set 20
V -109/18/25, 20:53 -
core-ci voted on patch set 20 V -1 09/18/25, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85133
-
Oli Bartsch uploaded patch set 21
V -109/18/25, 21:31 -
core-ci voted on patch set 21 V +1 09/18/25, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85135
-
Oli Bartsch uploaded patch set 22
V +109/23/25, 08:12 -
core-ci voted on patch set 22 V +1 09/23/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85370
-
Benni Mack uploaded patch set 23
V +109/23/25, 13:04 -
core-ci voted on patch set 23 V -1 09/23/25, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85384
-
Benni Mack uploaded patch set 24
V -109/23/25, 13:30 -
core-ci voted on patch set 24 V -1 09/23/25, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85386
-
Benni Mack uploaded patch set 25
V -109/23/25, 13:50 -
Benni Mack uploaded patch set 26 09/23/25, 13:57
-
core-ci voted on patch set 25 V -1 09/23/25, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85387
-
core-ci voted on patch set 26 V -1 09/23/25, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85389
-
Benni Mack uploaded patch set 27
V -109/23/25, 14:11 -
Benni Mack uploaded patch set 28 09/23/25, 14:19
-
core-ci voted on patch set 27 V -1 09/23/25, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85390
-
core-ci voted on patch set 28 V +1 09/23/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85391
-
Benni Mack uploaded patch set 29
V +109/23/25, 14:39 -
core-ci voted on patch set 29 V -1 09/23/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85392
-
Benni Mack uploaded patch set 30
V -109/23/25, 15:01 -
core-ci voted on patch set 30 V -1 09/23/25, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85393
-
Benni Mack uploaded patch set 31
V -109/23/25, 15:17 -
Benni Mack uploaded patch set 32 09/23/25, 15:26
-
core-ci voted on patch set 31 V -1 09/23/25, 15:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85395
-
core-ci voted on patch set 32 V -1 09/23/25, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85396
-
Benni Mack uploaded patch set 33
V -109/24/25, 06:23 -
core-ci voted on patch set 33 V +1 09/24/25, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85423
-
Benni Mack uploaded patch set 34
V +109/24/25, 12:21 -
core-ci voted on patch set 34 V +1 09/24/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85447
-
Simon Schaufelberger commented on patch set 34 09/24/25, 14:08
file_storage_indexing_task.php:14indentation can be reduced one leveloptimize_database_table_task.php:14indentation can be reduced one levelrecycler_garbage_collection_task.php:14indentation can be reduced one level
-
Benni Mack uploaded patch set 35
V +109/24/25, 14:24 -
Benni Mack commented on patch set 35 09/24/25, 14:24
TaskService.php:363Replyyes. in Install Tool.file_storage_indexing_task.php:14ReplyDoneoptimize_database_table_task.php:14ReplyDonerecycler_garbage_collection_task.php:14ReplyDone -
core-ci voted on patch set 35 V +1 09/24/25, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85452
-
Benni Mack uploaded patch set 36
V +109/24/25, 15:26 -
core-ci voted on patch set 36 V +1 09/24/25, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85457
-
Oli Bartsch uploaded patch set 37
V +109/24/25, 20:30 -
core-ci voted on patch set 37 V -1 09/24/25, 20:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85466
-
Oli Bartsch uploaded patch set 38
V -109/25/25, 08:33 -
core-ci voted on patch set 38 V -1 09/25/25, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85492
-
Oli Bartsch uploaded patch set 39
V -109/25/25, 09:29 -
core-ci voted on patch set 39 V -1 09/25/25, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85495
-
Oli Bartsch uploaded patch set 40
V -109/25/25, 09:46 -
core-ci voted on patch set 40 V -1 09/25/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85497
-
Oli Bartsch uploaded patch set 41
V -109/25/25, 11:12 -
core-ci voted on patch set 41 V +1 09/25/25, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85503
-
Oli Bartsch voted on patch set 41 CR +1 V +1 09/25/25, 11:25
-
Simon Schaufelberger commented on patch set 41 09/25/25, 12:01
scheduler_download_extensionlist_task.php:6I prefer having these classes being imported. Do you agree?scheduler_cleaner_task.php:6I prefer having these classes being imported. Do you agree?scheduler_caching_framework_garbage_collection_task.php:5I prefer having these classes being imported. Do you agree? -
Oli Bartsch commented on patch set 41 09/25/25, 12:03
scheduler_download_extensionlist_task.php:6ReplyFeel free to adjust I don't care.scheduler_cleaner_task.php:6ReplyDonescheduler_caching_framework_garbage_collection_task.php:5ReplyDone -
Simon Schaufelberger uploaded patch set 42
CR +1V +109/25/25, 12:45 -
Georg Ringer voted on patch set 42 CR +1 V +1 09/25/25, 12:52
-
Simon Schaufelberger voted on patch set 42 CR +1 09/25/25, 12:53
-
core-ci voted on patch set 42 V +1 09/25/25, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85518
-
Garvin Hicking commented on patch set 42 CR +1 V +1 09/25/25, 13:37
YES! Kudos, I followed this for long and really admire the effort put into this. Thanks! -
Oli Bartsch voted on patch set 42 CR +2 V +2 09/25/25, 13:42
-
Oli Bartsch merged patch set 43 09/25/25, 13:42
TaskService.php:363