Review main Merged

89614[BUGFIX] Correctly hard-delete inline foreign field children

Christian Kuhn CR +2 V +2 Normal +44 −19 updated 06/03/25, 18:21

Commit message

This one was found by one of the flex->inline tests when
working on #79014 tests: When a parent record that has
more than one inline child is hard-deleted after it has
been soft-deleted (typically using the recycler), attached
children have to be hard-deleted as well, but are not.
It works when only child is attached, though.

The reason is a detail in PlainDataResolver that takes care
of resorting given child ids. Beside the situation that
resorting is probably not needed in the delete case,
processSorting() also applies the deleted restriction to
the query that is used to resort and thus "looses"
soft-deleted records.

The solution is to never apply the DeletedRestriction in
order to retain the full list of incoming ids when bringing
records into the correct order, since deleted restrictions
should have been applied already if needed - typically by
RelationHandler.

The patch resolves according @todo comments from #79014
and adds a test for a "simple" parent->inline
foreign_field scenario that does not involve flex forms.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1423

  1. Christian Kuhn uploaded patch set 1 06/03/25, 13:33

  2. core-ci voted on patch set 1 V -1 06/03/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79800

  3. Christian Kuhn uploaded patch set 2 V -1 06/03/25, 13:52

  4. core-ci voted on patch set 2 V +1 06/03/25, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79802

  5. Christian Kuhn uploaded patch set 3 V +1 06/03/25, 14:13

  6. Christian Kuhn uploaded patch set 4 06/03/25, 14:15

  7. Christian Kuhn uploaded patch set 5 06/03/25, 14:19

  8. core-ci voted on patch set 3 V +1 06/03/25, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79804

  9. core-ci voted on patch set 4 V +1 06/03/25, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79805

  10. core-ci voted on patch set 5 V +1 06/03/25, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79806

  11. Christian Kuhn uploaded patch set 6 V +1 06/03/25, 14:40

  12. core-ci voted on patch set 6 V +1 06/03/25, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79807

  13. Christian Kuhn uploaded patch set 7 V +1 06/03/25, 14:57

  14. Christian Kuhn updated the commit message in patch set 8 06/03/25, 15:02

  15. core-ci voted on patch set 7 V +1 06/03/25, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79808

  16. core-ci voted on patch set 8 V +1 06/03/25, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79809

  17. Stefan Bürk voted on patch set 8 CR +1 06/03/25, 15:30

  18. Christian Kuhn updated the commit message in patch set 9 CR +1 V +1 06/03/25, 15:58

  19. core-ci voted on patch set 9 V +1 06/03/25, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79811

  20. Stefan Bürk voted on patch set 9 CR +1 V +1 06/03/25, 16:13

  21. Oli Bartsch voted on patch set 9 CR +1 V +1 06/03/25, 16:40

  22. Christian Kuhn voted on patch set 9 CR +2 V +2 06/03/25, 18:21

  23. Christian Kuhn merged patch set 10 06/03/25, 18:21