Review 13.4 Merged

89629[TASK] Remove IrreForeignFieldNonWs tests

Christian Kuhn CR +2 V +2 Nightmare +0 −5683 updated 06/04/25, 13:39

Commit message

The IrreForeignFieldNonWs tests reflect the scenario
"an inline parent is workspace aware, an inline child
is not". This has been declared unsupported in main
with #106821. The scenario is so full of issues that
the tests actively prevent fixing other issues. With
the scenario being avoided in main and any issues no
longer being fixed in v13, the tests are now removed
in v13 to unblock fixing other things. Note there is
a last comment in DataHandler mentioning the tests.
This will be cleaned up with another change since the
code covers multiple slightly different scenarios
as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 84

Show 64 more files

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/04/25, 13:29

  2. Christian Kuhn updated the commit message in patch set 2 06/04/25, 13:29

  3. Stefan Bürk voted on patch set 2 CR +1 V +1 06/04/25, 13:31

  4. Oli Bartsch voted on patch set 2 CR +1 V +1 06/04/25, 13:33

  5. core-ci voted on patch set 1 V +1 06/04/25, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79861

  6. core-ci voted on patch set 2 V +1 06/04/25, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79862

  7. Christian Kuhn commented on patch set 2 CR +2 V +2 06/04/25, 13:39

    will merge right away: the tests are more a hindrance than help and have been removed in main already.
  8. Christian Kuhn merged patch set 3 06/04/25, 13:39