Review main Abandoned Breaking

89630[!!!][TASK] Refactor PlainDataResolver

Daniel Windloff CR 0 V 0 Hard +449 −244 updated 10/31/25, 10:18

Commit message

*TCA Schema API
The PlainDataResolver uses the schema of a TCA table instead of the table name
to resolve the possibility to have workspace versions.
Furthermore, two flags to get sorting criteria based on the TCA configuration `sortby` and  `default_sortby` has been added.

*Service
The PlainDataResolver now can be used as a service.
For this reason it now should be injected via constructor injection.

* Php types
For all method calls, php types has been introduced.
The `PlainDataResolver` also uses strict types.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 12

Review log 69

  1. Daniel Windloff uploaded patch set 1 06/04/25, 14:05

  2. core-ci voted on patch set 1 V -1 06/04/25, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79866

  3. Daniel Windloff uploaded patch set 2 V -1 06/04/25, 14:31

  4. core-ci voted on patch set 2 V +1 06/04/25, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79869

  5. Daniel Windloff uploaded patch set 3 V +1 09/19/25, 10:18

  6. core-ci voted on patch set 3 V +1 09/19/25, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85158

  7. Benni Mack commented on patch set 3 09/22/25, 18:42

    Hey Daniel, I don't fully grasp this change - or the reason / need for this change. PlainDataResolver is very very lowlevel. I hope (almost) nobody is using this in their user-land projects. Are you planning a bigger series of refactorings? Here is my take on this: We have the PlainDataResolver and RelationHandler etc. _If_ I'd refactor them, I'd rather use full rows rather than IDs to juggle around, split up RelationHandler into read+write, and probably combine the power of the PlainDataResolver with the read-logic of RelationHandler. This would be a breaking change - or probably rather a new API, thus, deprecating PlainDataResolver in the mid-run. However, if you have other plans on how the internal API could work, I'd love to know them so we can coordinate our efforts.
  8. Daniel Windloff commented on patch set 3 10/26/25, 14:38

    Reply Unresolved

    Hey Benni, as far as I see is the PlainDataResover a (leaf) dependency of the DataHandler, so I thought it's a good starting point for a refactoring in order to remove internal state there first. I haven't analysed the RelationHandler in detail yet, but splitting and using records sounds good.
  9. Daniel Windloff abandoned the change 10/31/25, 10:18

    would be solved diffrently