89630[!!!][TASK] Refactor PlainDataResolver
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+23 −27
- typo3/sysext/core/Classes/Database/RelationHandler.php+23 −29
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+12 −23
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php+71 −163
- typo3/sysext/core/Classes/DataHandling/PlainDataResolverConfiguration.phpnew+73 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-106809-RefactorPlainDataResolver.rstnew+87 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataResolving/DataSet/Tt_content_applyLive.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataResolving/PlainDataResolverTest.php+107 −2
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+6 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstructorArgumentMatcher.php+8 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentRequiredMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+28 −0
Review log 69
-
Daniel Windloff uploaded patch set 1 06/04/25, 14:05
-
core-ci voted on patch set 1 V -1 06/04/25, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79866
-
Daniel Windloff uploaded patch set 2
V -106/04/25, 14:31 -
core-ci voted on patch set 2 V +1 06/04/25, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79869
-
Daniel Windloff uploaded patch set 3
V +109/19/25, 10:18 -
core-ci voted on patch set 3 V +1 09/19/25, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85158
-
Benni Mack commented on patch set 3 09/22/25, 18:42
Hey Daniel, I don't fully grasp this change - or the reason / need for this change. PlainDataResolver is very very lowlevel. I hope (almost) nobody is using this in their user-land projects. Are you planning a bigger series of refactorings? Here is my take on this: We have the PlainDataResolver and RelationHandler etc. _If_ I'd refactor them, I'd rather use full rows rather than IDs to juggle around, split up RelationHandler into read+write, and probably combine the power of the PlainDataResolver with the read-logic of RelationHandler. This would be a breaking change - or probably rather a new API, thus, deprecating PlainDataResolver in the mid-run. However, if you have other plans on how the internal API could work, I'd love to know them so we can coordinate our efforts. -
Daniel Windloff commented on patch set 3 10/26/25, 14:38
Reply Unresolved
Hey Benni, as far as I see is the PlainDataResover a (leaf) dependency of the DataHandler, so I thought it's a good starting point for a refactoring in order to remove internal state there first. I haven't analysed the RelationHandler in detail yet, but splitting and using records sounds good. -
Daniel Windloff abandoned the change 10/31/25, 10:18
would be solved diffrently