Review main Merged

89631[TASK] Sort the localization diffsource field alphabetically

Christian Kuhn CR +2 V +2 Easy +24 −23 updated 06/04/25, 16:52

Commit message

The TCA ctrl "transOrigDiffSourceField" tracks content
changes between default language records and localized
records as json data.
The patch adds a simple ksort() before data is written
to DB by DataHandler.
This is db-wise rather cosmetical and has no further
impact, but it simplifies test maintenance since the
content no longer changes when TCA columns are resorted.

Note the v13 will keep method fillInFieldArray() public.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1016

  1. Christian Kuhn uploaded patch set 1 06/04/25, 14:09

  2. core-ci voted on patch set 1 V -1 06/04/25, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79867

  3. Christian Kuhn uploaded patch set 2 V -1 06/04/25, 14:47

  4. Christian Kuhn uploaded patch set 3 06/04/25, 14:52

  5. Christian Kuhn uploaded patch set 4 06/04/25, 14:55

  6. core-ci voted on patch set 2 V -1 06/04/25, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79870

  7. core-ci voted on patch set 4 V +1 06/04/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79872

  8. Christian Kuhn updated the commit message in patch set 5 V +1 06/04/25, 15:04

  9. core-ci voted on patch set 3 V -1 06/04/25, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79871

  10. Christian Kuhn updated the commit message in patch set 6 06/04/25, 15:05

  11. core-ci voted on patch set 5 V +1 06/04/25, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79874

  12. core-ci voted on patch set 6 V +1 06/04/25, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79875

  13. Benni Mack commented on patch set 6 CR +1 V +1 06/04/25, 15:34

    thanks for cleaning this up, it was a burden for so many DB diffs and creating patches in the past
  14. Stefan Bürk voted on patch set 6 CR +1 V +1 06/04/25, 16:10

  15. Christian Kuhn voted on patch set 6 CR +2 V +2 06/04/25, 16:36

  16. Christian Kuhn merged patch set 7 06/04/25, 16:52