Review 13.4 Merged

89636[TASK] Skip language related fields in diffsource json

Christian Kuhn CR +2 V +2 Normal +38 −29 updated 06/04/25, 19:13

Commit message

The TCA ctrl "transOrigDiffSourceField" tracks content
changes of the default language record in localized
records to notify editors "something changed in the
default language record, you may want to check if the
localization needs adaptions".

The patch takes care some of the default language
record field changes are no longer stored in this
json field since it does not make sense to store them:

* TCA ctrl "languageField" (typically sys_language_uid).
  This is 0 in the default language record by definition.
  There is no point in storing this in the diffsource field.
* Same as above with "transOrigPointerField" (typically
  l10n_parent) and "translationSource" (typically
  l10n_source).
* The diffsource field itself, obviously.

We don't "migrate away" affected existing content since it
does not hurt much. Instead, we simply rely on the data being
cleaned up automatically when affected records are changed
next time using the DataHandler.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 14

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/04/25, 18:52

  2. core-ci voted on patch set 1 V +1 06/04/25, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79890

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/04/25, 19:12

  4. Christian Kuhn merged patch set 2 06/04/25, 19:13