Review main Merged

89638[TASK] Add EXT:styleguide imagemanipulation example file_1

Garvin Hicking CR +2 V +2 Normal +172 −8 updated 06/06/25, 06:30

Commit message

EXT:styleguide currently has three 'sys_file' inputs to enter a file
for the "imagemanipulation" element group.

This is unfortunate, because no file picker can be used here, records
need to be entered by UID. Due to type=group & allowed=sys_file,
the record selector yields no file tree or records.

To ease this up for testing, a new "file_1" column has been
introduced, which also now showcases inline cropVariant configs
via TCA childOverride. This was not covered yet and repesents
a commonly used practice in integrations. The TCA
override only covers the crop configuration to be applied in
FormEngine context, DataHandler does not need to deal with
this at this place.

As a drive-by change, the "tall" crop config is enlarged a bit
to make testing easier, because it easily created way too small
aspect crop areas.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 710

  1. Garvin Hicking uploaded patch set 1 06/05/25, 07:21

  2. core-ci voted on patch set 1 V +1 06/05/25, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79909

  3. Christian Kuhn updated the commit message in patch set 2 V +1 06/05/25, 08:03

  4. core-ci voted on patch set 2 V +1 06/05/25, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79912

  5. Garvin Hicking commented on patch set 3 V +1 06/05/25, 09:10

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 06/05/25, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79915

  7. Christian Kuhn voted on patch set 3 CR +1 V +1 06/05/25, 09:37

  8. Georg Ringer voted on patch set 3 CR +1 V +1 06/06/25, 05:24

  9. Garvin Hicking voted on patch set 3 CR +2 V +2 06/06/25, 05:56

  10. Garvin Hicking merged patch set 4 06/06/25, 06:30